Skip to content

Issue-4087: Increase MaxItems for CACertificateRefs validation - #4088

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
root30:issue-4087
Apr 27, 2026
Merged

k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
root30:issue-4087

Conversation

@root30

@root30 root30 commented Sep 15, 2025 •

Copy link
Copy Markdown
Contributor

What type of PR is this?
kind feature

What this PR does / why we need it:
Increase the number of allowed Certificate Authority references

Which issue(s) this PR fixes:

Fixes #4087

Does this PR introduce a user-facing change?:

Increase the number of allowed Certificate Authority references from `8` to `16`

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 15, 2025
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Hi @root30. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 15, 2025
@k8s-triage-robot

Copy link
Copy Markdown

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 15, 2025
@snorwin

snorwin commented Dec 29, 2025

Copy link
Copy Markdown
Member

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 29, 2025
@snorwin

snorwin commented Dec 29, 2025

Copy link
Copy Markdown
Member

/cc @rikatz @kl52752

@snorwin

snorwin commented Dec 29, 2025

Copy link
Copy Markdown
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 29, 2025

@snorwin snorwin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @root30!

It sounds reasonable to give administrators a bit more flexibility in how they choose to split their trusted CA bundles across resources.

@kl52752

kl52752 commented Jan 15, 2026

Copy link
Copy Markdown
Contributor

One think that worries me is the size of Gateway object and I'm fine with increasing the number but I'm worried that 32 is too much.
Frontend validation is set on gateway as Default value and per port overrides. We allows to set 64 per port overrides which equals Listeners max number. In worst case scenario will have 65 * 32 references which seams a lot.

@snorwin

snorwin commented Jan 15, 2026

Copy link
Copy Markdown
Member

@kl52752 how about increasing it to 16 as a compromise? 😉

@kl52752

kl52752 commented Jan 15, 2026

Copy link
Copy Markdown
Contributor

yeah we can meet half way :)

@youngnick @robscott do you have any concerns about increasing this limitation?

@root30
root30 force-pushed the issue-4087 branch 3 times, most recently from e5f6bdc to 0eb22ee Compare January 22, 2026 16:48
@rikatz

rikatz commented Jan 26, 2026

Copy link
Copy Markdown
Member

Bumping to 16 makes sense, I think that more than it we may start getting massive sizes
eg.: you have now something like

".spec.tls.frontend.perPort[0-63].tls.validation.caCertificateRefs[0-15]"

which may end up with 1024 different combinations (if my math doesn't fail me) of entries. If each of these entries represents 1kb, you now have 1Mb of data just for the tls configuration (etcd by default limits to 1.5mb: https://etcd.io/docs/v3.6/dev-guide/limit/). So given this + all of the other array fields, we are dangerously close to the limits.

/approve
/hold
@youngnick @robscott for the lgtm

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 26, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rikatz, root30

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2026
@howardjohn

Copy link
Copy Markdown
Contributor

If a user accidentally hits 1.5mb, its not really a problem. etcd will reject it, which is the same as CEL rejecting it. We need not fear the 1.5mb limit unless we are pushing reasonable users to hit it (i.e. if we allowed infinite Listeners, and used that as a justification to not build ListenerSet)

@snorwin

snorwin commented Feb 20, 2026

Copy link
Copy Markdown
Member

/check-cla

@root30 root30 closed this Feb 20, 2026
@root30 root30 reopened this Feb 20, 2026
@rikatz

rikatz commented Apr 23, 2026

Copy link
Copy Markdown
Member

/lgtm
/retest
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 23, 2026
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 23, 2026
@rikatz

rikatz commented Apr 23, 2026

Copy link
Copy Markdown
Member

@root30 you need to run 'make generate' (or make manifests, cant remember) and rebase over main, can you do it please? Thanks!

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 24, 2026
@rikatz

rikatz commented Apr 27, 2026

Copy link
Copy Markdown
Member

/lgtm
thanks

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 27, 2026
@k8s-ci-robot
k8s-ci-robot merged commit 23d7f00 into kubernetes-sigs:main Apr 27, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Increase the number of allowed Certificate Authority references

7 participants