Repository navigation
Issue-4087: Increase MaxItems for CACertificateRefs validation - #4088
Conversation
|
Hi @root30. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
|
/remove-lifecycle stale |
|
/ok-to-test |
|
One think that worries me is the size of Gateway object and I'm fine with increasing the number but I'm worried that 32 is too much. |
|
@kl52752 how about increasing it to 16 as a compromise? 😉 |
|
yeah we can meet half way :) @youngnick @robscott do you have any concerns about increasing this limitation? |
e5f6bdc to
0eb22ee
Compare
|
Bumping to 16 makes sense, I think that more than it we may start getting massive sizes ".spec.tls.frontend.perPort[0-63].tls.validation.caCertificateRefs[0-15]" which may end up with 1024 different combinations (if my math doesn't fail me) of entries. If each of these entries represents 1kb, you now have 1Mb of data just for the tls configuration (etcd by default limits to 1.5mb: https://etcd.io/docs/v3.6/dev-guide/limit/). So given this + all of the other array fields, we are dangerously close to the limits. /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rikatz, root30 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
If a user accidentally hits 1.5mb, its not really a problem. etcd will reject it, which is the same as CEL rejecting it. We need not fear the 1.5mb limit unless we are pushing reasonable users to hit it (i.e. if we allowed infinite Listeners, and used that as a justification to not build ListenerSet) |
|
/check-cla |
|
/lgtm |
|
@root30 you need to run 'make generate' (or make manifests, cant remember) and rebase over main, can you do it please? Thanks! |
|
/lgtm |
What type of PR is this?
kind feature
What this PR does / why we need it:
Increase the number of allowed Certificate Authority references
Which issue(s) this PR fixes:
Fixes #4087
Does this PR introduce a user-facing change?: