Repository navigation
Define union features - #4452
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rikatz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| TODO: Maybe mention that ReferenceGrant is the same case. | ||
| TODO: Define how this applies with conformance profiles. |
There was a problem hiding this comment.
I think the other unanswered question here is: as an implementor or user, how do you know? Right now, I think the only way is to run the conformance tests and see something fail.
There was a problem hiding this comment.
right, I wanted to initially write the conformance tests for these cases as well. But in case we miss some conformance, this would never be "clear".
I was wondering if a feature or a profile that signals a union feature would be enough to be a commitment from the implementation of doing it, and for users to knowing the desired behavior
There was a problem hiding this comment.
I wonder if it's worth trying to do some sort of description of the combinations. 🤔 All of the options here seem less than ideal – the conformance tests may be the best option we have, but I'd be happier having something (maybe pulled out of the conformance tests?) talking about the combinations needed... 🤔
There was a problem hiding this comment.
I was wondering if this should be a new flag on conformance that an implementation would opt-out (or some meta-feature)
There was a problem hiding this comment.
It might be nice if we could surface these unions up through docs similar to how we populate the Experimental tag like https://gateway-api.sigs.k8s.io/reference/spec/#httpexternalauthfilter
So you could see resources that BackendTLSPolicy is expected to interop with in its docs for example.
There was a problem hiding this comment.
hum, yeah, maybe as a followup I agree, but I wouldn't block this effort right now just on it.
Maybe open an issue for it Mike, and we can work on it. Doing these stuff on API Reference Doc is "slightly" boring so we will need to generate a new tag for something like //+unionFeature: BackendTLSPolicy and make the crd-ref-docs binary understand and parse it. not impossible, but not straightforward
|
@rikatz, in the interests of the next release – maybe update this doc with the combinations you're currently concerned about? Then we can land the doc update and decouple the conformance tests. |
|
/cc |
|
I think that there's probably some optimization we can do about how we talk about features in general, but I also think that something like this is important right now, so this should go ahead, and we can clean up the larger picture later. So, /lgtm |
9905111 to
2ccfdbf
Compare
|
Thanks @rikatz! /lgtm |
What type of PR is this?
/kind documentation
/kind feature
What this PR does / why we need it:
Defines the concept of
Union featureand how it applies to features like BackendTLSPolicyWhich issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: