Skip to content

conformance: client certificate AllowInsecureFallback validation mode tests - #4468

Merged
k8s-ci-robot merged 6 commits into
kubernetes-sigs:mainfrom
snorwin:allow-insecure-fallback-tests
Feb 19, 2026
Merged

k8s-ci-robot merged 6 commits into
kubernetes-sigs:mainfrom
snorwin:allow-insecure-fallback-tests

Conversation

@snorwin

@snorwin snorwin commented Jan 29, 2026

Copy link
Copy Markdown
Member

What type of PR is this?

/kind test

What this PR does / why we need it:
This PR adds a conformance test for the AllowInsecureFallback client certificate validation mode. It also introduces an extended feature for this mode and fixes a typo where the InsecureFrontendValidationMode status condition was incorrectly specified as the reason in the API.

Which issue(s) this PR fixes:

N/A

Does this PR introduce a user-facing change?:

NONE

@snorwin

snorwin commented Jan 29, 2026

Copy link
Copy Markdown
Member Author

/cc @rikatz @kl52752

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/test labels Jan 29, 2026
@k8s-ci-robot
k8s-ci-robot requested a review from kflynn January 29, 2026 19:55
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 29, 2026
@snorwin snorwin changed the title confomance: client certifcate AllowInsecureFallback validation mode tests conformance: client certifcate AllowInsecureFallback validation mode tests Jan 29, 2026
@snorwin snorwin changed the title conformance: client certifcate AllowInsecureFallback validation mode tests conformance: client certificate AllowInsecureFallback validation mode tests Jan 29, 2026
@rikatz

rikatz commented Feb 2, 2026

Copy link
Copy Markdown
Member

/lgtm

/cc @kl52752 @robscott

@k8s-ci-robot
k8s-ci-robot requested a review from robscott February 2, 2026 16:50
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 2, 2026
frontend:
default:
validation:
mode: AllowInsecureFallback

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to have test where

  1. only perPort configuration has mode AllowInsecureFallback and we will verify that this mode does not impact default config. Validation with 3 kind of request is great :)
  2. update default configuration to AllowInsecureFallback and verify that condition was set
  3. delete mode from default conf and verify that condition was removed

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi everyone,

Am I correct in assuming that this PR is intended to be merged for the v1.5 release? If so, are there any additional opinions on the original code or suggestion by @kl52752 ?
I am not very familiar with the style of the Conformance tests and whether we usually reconfigure the Gateway during a single test case. However I like your suggestion.

The author is currently on vacation and won’t be able to participate in the discussion.

How would you suggest we proceed?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature is in "Extended" support looking at tight deadline for v1.5 I think we can merge this later.
@robscott @rikatz @youngnick what do you think?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the release branch is being cut today, we'll still have until ~Wednesday next week to cherry-pick this in. Would love to squeeze it in if we can, but agree that it doesn't strictly block the feature from getting through.

@robscott robscott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @snorwin!

frontend:
default:
validation:
mode: AllowInsecureFallback

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the release branch is being cut today, we'll still have until ~Wednesday next week to cherry-pick this in. Would love to squeeze it in if we can, but agree that it doesn't strictly block the feature from getting through.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 6, 2026
@root30

root30 commented Feb 6, 2026

Copy link
Copy Markdown
Contributor

@kl52752 @rikatz @robscott Based on my understanding, this PR looks good be merged. Could someone please take care of rebasing it? very appreciated, thanks 🙏

@kl52752

kl52752 commented Feb 6, 2026

Copy link
Copy Markdown
Contributor

@kl52752 @rikatz @robscott Based on my understanding, this PR looks good be merged. Could someone please take care of rebasing it? very appreciated, thanks 🙏

I think that those test cases needs to be improved #4468 (comment).

@snorwin is OOO for 2 weeks, can we wait till he come back to make this resolved?

@snorwin
snorwin force-pushed the allow-insecure-fallback-tests branch from 7ab9bf5 to cab19ab Compare February 16, 2026 13:07
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 16, 2026
@snorwin
snorwin requested a review from kl52752 February 16, 2026 13:08
@snorwin

snorwin commented Feb 16, 2026

Copy link
Copy Markdown
Member Author

/retest

1 similar comment
@snorwin

snorwin commented Feb 16, 2026

Copy link
Copy Markdown
Member Author

/retest

@snorwin

snorwin commented Feb 17, 2026

Copy link
Copy Markdown
Member Author

@kubernetes-sigs/gateway-api-maintainers I’d really appreciate it if we could include this in the 1.5.0 release as well. PTAL.

Thanks a lot!

@youngnick

Copy link
Copy Markdown
Contributor

I think that the included fix is very important, and it makes sense to test that behavior as well.

I agree with @kl52752 that we should add other conformance tests as well, but that shouldn't stop us adding this one first.

/approve

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: snorwin, youngnick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2026
@robscott

Copy link
Copy Markdown
Member

Thanks @snorwin!

/lgtm
/cherry-pick release-1.5

@k8s-infra-cherrypick-robot

Copy link
Copy Markdown
Contributor

@robscott: once the present PR merges, I will cherry-pick it on top of release-1.5 in a new PR and assign it to you.

Details

In response to this:

Thanks @snorwin!

/lgtm
/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 19, 2026
…tion mode

Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>
Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>
Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>
Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>
Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>
Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>
@snorwin
snorwin force-pushed the allow-insecure-fallback-tests branch from a87f2d8 to 729464a Compare February 19, 2026 08:02
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 19, 2026
@snorwin

snorwin commented Feb 19, 2026

Copy link
Copy Markdown
Member Author

@robscott could you please re-add the lgtm label? I had to rebase again. Thanks a lot.

@kl52752

kl52752 commented Feb 19, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 19, 2026
@k8s-ci-robot
k8s-ci-robot merged commit 1fd08a3 into kubernetes-sigs:main Feb 19, 2026
20 checks passed
@k8s-infra-cherrypick-robot

Copy link
Copy Markdown
Contributor

@robscott: new pull request created: #4564

Details

In response to this:

Thanks @snorwin!

/lgtm
/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

danehans pushed a commit to danehans/gateway-api that referenced this pull request Mar 10, 2026
… tests (kubernetes-sigs#4468)

* conformance tests for AllowInsecureFallback client certificate validation mode

Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>

* api: refine InsecureFrontendValidationMode condition and descriptions

Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>

* add feature GatewayFrontendClientCertificateValidationInsecureFallback

Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>

* fix linting issues

Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>

* apply PR feedback

Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>

* remove copyright years after 2025

Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>

---------

Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/test lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants