Repository navigation
conformance: client certificate AllowInsecureFallback validation mode tests - #4468
Conversation
| frontend: | ||
| default: | ||
| validation: | ||
| mode: AllowInsecureFallback |
There was a problem hiding this comment.
I think it would be better to have test where
- only perPort configuration has mode AllowInsecureFallback and we will verify that this mode does not impact default config. Validation with 3 kind of request is great :)
- update default configuration to AllowInsecureFallback and verify that condition was set
- delete mode from default conf and verify that condition was removed
There was a problem hiding this comment.
Hi everyone,
Am I correct in assuming that this PR is intended to be merged for the v1.5 release? If so, are there any additional opinions on the original code or suggestion by @kl52752 ?
I am not very familiar with the style of the Conformance tests and whether we usually reconfigure the Gateway during a single test case. However I like your suggestion.
The author is currently on vacation and won’t be able to participate in the discussion.
How would you suggest we proceed?
There was a problem hiding this comment.
This feature is in "Extended" support looking at tight deadline for v1.5 I think we can merge this later.
@robscott @rikatz @youngnick what do you think?
There was a problem hiding this comment.
While the release branch is being cut today, we'll still have until ~Wednesday next week to cherry-pick this in. Would love to squeeze it in if we can, but agree that it doesn't strictly block the feature from getting through.
| frontend: | ||
| default: | ||
| validation: | ||
| mode: AllowInsecureFallback |
There was a problem hiding this comment.
While the release branch is being cut today, we'll still have until ~Wednesday next week to cherry-pick this in. Would love to squeeze it in if we can, but agree that it doesn't strictly block the feature from getting through.
I think that those test cases needs to be improved #4468 (comment). @snorwin is OOO for 2 weeks, can we wait till he come back to make this resolved? |
7ab9bf5 to
cab19ab
Compare
|
/retest |
1 similar comment
|
/retest |
|
@kubernetes-sigs/gateway-api-maintainers I’d really appreciate it if we could include this in the 1.5.0 release as well. PTAL. Thanks a lot! |
|
I think that the included fix is very important, and it makes sense to test that behavior as well. I agree with @kl52752 that we should add other conformance tests as well, but that shouldn't stop us adding this one first. /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: snorwin, youngnick The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks @snorwin! /lgtm |
|
@robscott: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
…tion mode Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>
Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>
Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>
Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>
Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>
Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>
a87f2d8 to
729464a
Compare
|
@robscott could you please re-add the lgtm label? I had to rebase again. Thanks a lot. |
|
/lgtm |
|
@robscott: new pull request created: #4564 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
… tests (kubernetes-sigs#4468) * conformance tests for AllowInsecureFallback client certificate validation mode Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com> * api: refine InsecureFrontendValidationMode condition and descriptions Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com> * add feature GatewayFrontendClientCertificateValidationInsecureFallback Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com> * fix linting issues Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com> * apply PR feedback Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com> * remove copyright years after 2025 Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com> --------- Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>
What type of PR is this?
/kind test
What this PR does / why we need it:
This PR adds a conformance test for the
AllowInsecureFallbackclient certificate validation mode. It also introduces an extended feature for this mode and fixes a typo where theInsecureFrontendValidationModestatus condition was incorrectly specified as the reason in the API.Which issue(s) this PR fixes:
N/A
Does this PR introduce a user-facing change?: