Skip to content

conformance: Re-add ListenerSetAllowedRoutesSupportedKinds - #4512

Merged
k8s-ci-robot merged 3 commits into
kubernetes-sigs:mainfrom
davidjumani:readd-lset-test
Feb 13, 2026
Merged

k8s-ci-robot merged 3 commits into
kubernetes-sigs:mainfrom
davidjumani:readd-lset-test

Conversation

@davidjumani

@davidjumani davidjumani commented Feb 6, 2026 •

Copy link
Copy Markdown
Contributor

What type of PR is this?

Add one of the following kinds:
/kind test

/area conformance-test

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #4497

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 6, 2026
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 6, 2026
Comment thread apis/v1/gateway_types.go Resolved
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 6, 2026
@davidjumani

Copy link
Copy Markdown
Contributor Author

Verified this works on kgateway

--- PASS: TestConformance/ListenerSetAllowedRoutesSupportedKinds (3.04s)

@robscott robscott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @davidjumani!

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 11, 2026
@youngnick

Copy link
Copy Markdown
Contributor

This change is pushing us to clarify something we had not before - what happens with supportedKinds when a Listener is not Accepted? We haven't actually been specific about this before, and haven't checked in any conformance tests, so up until now it has been valid to set supportedKinds even when the Listener is not Accepted.

This change moves us towards mandating that supportedKinds must be empty when Accepted is status: false. Which is probably fine, but is a change. (I'll have to fix Cilium for it).

@davidjumani

Copy link
Copy Markdown
Contributor Author

Updated the test based on the discussion on slack

@robscott robscott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @davidjumani! Will defer to @youngnick for final LGTM.

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidjumani, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@robscott

Copy link
Copy Markdown
Member

/cherry-pick release-1.5

@k8s-infra-cherrypick-robot

Copy link
Copy Markdown
Contributor

@robscott: once the present PR merges, I will cherry-pick it on top of release-1.5 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@youngnick

Copy link
Copy Markdown
Contributor

Thanks for the patience, @davidjumani. Nice work.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2026
@k8s-ci-robot
k8s-ci-robot merged commit e0bee71 into kubernetes-sigs:main Feb 13, 2026
20 checks passed
@k8s-infra-cherrypick-robot

Copy link
Copy Markdown
Contributor

@robscott: new pull request created: #4535

Details

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

danehans pushed a commit to danehans/gateway-api that referenced this pull request Mar 10, 2026
…s-sigs#4512)

* conformance: Re-add ListenerSetAllowedRoutesSupportedKinds

* update json tags

* update test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Readd ListenerSetAllowedRoutesSupportedKinds

6 participants