Repository navigation
conformance: Re-add ListenerSetAllowedRoutesSupportedKinds - #4512
Conversation
4a89720 to
b05d27a
Compare
|
Verified this works on kgateway |
|
This change is pushing us to clarify something we had not before - what happens with This change moves us towards mandating that |
|
Updated the test based on the discussion on slack |
robscott
left a comment
There was a problem hiding this comment.
Thanks @davidjumani! Will defer to @youngnick for final LGTM.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidjumani, robscott The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-1.5 |
|
@robscott: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Thanks for the patience, @davidjumani. Nice work. /lgtm |
|
@robscott: new pull request created: #4535 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
…s-sigs#4512) * conformance: Re-add ListenerSetAllowedRoutesSupportedKinds * update json tags * update test
What type of PR is this?
Add one of the following kinds:
/kind test
/area conformance-test
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #4497
Does this PR introduce a user-facing change?: