Repository navigation
promote CORS to standard - #4521
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rikatz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
80ba203 to
6828669
Compare
|
/hold cancel |
|
/retest-required |
| // authentication strategies, rate-limiting, and traffic shaping. API | ||
| // guarantee/conformance is defined based on the type of the filter. | ||
| // | ||
| // +kubebuilder:validation:XValidation:message="filter.cors must be nil if the filter.type is not CORS",rule="!(has(self.cors) && self.type != 'CORS')" |
There was a problem hiding this comment.
had to move this up because apparently VAP needs some alphabetical order to proper validation, otherwise the tests fail
There was a problem hiding this comment.
(This is not intended to be a blocking comment)
There was a problem hiding this comment.
apparently it runs on the appearance mode (not alphabetical, sorry). So on an environment where it tries to validate HTTPRequestHeader before Cors, it will give its error first and never arrive CORS, even CORS appearing first.
It is weird, I dont have a better explanation for it :D
| // authentication strategies, rate-limiting, and traffic shaping. API | ||
| // guarantee/conformance is defined based on the type of the filter. | ||
| // | ||
| // +kubebuilder:validation:XValidation:message="filter.cors must be nil if the filter.type is not CORS",rule="!(has(self.cors) && self.type != 'CORS')" |
|
/cherry-pick release-1.5 |
|
@robscott: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@robscott: new pull request created: #4526 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
* promote CORS to standard * promote CORS to standard - generated files * cors: promote tests and add additional cases * cors: promote feature flag
What type of PR is this?
/kind feature
What this PR does / why we need it:
Promote CORS filter to standard
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: