Repository navigation
VAP for release v1.5 - #4533
VAP for release v1.5#4533
Conversation
β¦yaml Co-authored-by: Flynn <kflynn@users.noreply.github.com>
Co-authored-by: Ricardo Pchevuzinske Katz <rikatz@users.noreply.github.com>
Signed-off-by: Chris Kaiser <58376705+chris-kaiser-7@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: robscott The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-1.5 |
|
@robscott: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
dec32d0 to
d2c4c02
Compare
d2c4c02 to
c3caf9a
Compare
|
/retest |
|
Looks reasonable from here, thanks @robscott! /lgtm |
|
LGTM from me too. /unhold |
|
@robscott: new pull request created: #4534 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hi @robscott Thanks for merging this! I haven't had a chance to check in in a bit so nice to see this merged. |
|
Setting the channel to standard on the vap-safeupgrade breaks applying the experimental CRDs to clusters due to the vap-safeguard introspection checks. |
* added vap for experimental crds on standard crds * tidy * added validation for older versions * Update config/crd/standard/gateway.networking.k8s.io_safeUpgradesVAP.yaml Co-authored-by: Flynn <kflynn@users.noreply.github.com> * added x-k8s to validation * tidy * tidy * added validation and tidy * renamed vaps. * added tests for VAP and tidy * added resource rules to vap binding. * added note in RELEASE.md * removed manadest for modifying existing crd. * Update tests/crd/crd_test.go Co-authored-by: Ricardo Pchevuzinske Katz <rikatz@users.noreply.github.com> * refactored vap tests to seperate package Signed-off-by: Chris Kaiser <58376705+chris-kaiser-7@users.noreply.github.com> * A few minor cleanups --------- Signed-off-by: Chris Kaiser <58376705+chris-kaiser-7@users.noreply.github.com> Co-authored-by: Christopher Kaiser <58376705+chris-kaiser-7@users.noreply.github.com> Co-authored-by: Flynn <kflynn@users.noreply.github.com> Co-authored-by: Ricardo Pchevuzinske Katz <rikatz@users.noreply.github.com>
What type of PR is this?
/kind feature
What this PR does / why we need it:
This is a follow up to @chris-kaiser's excellent work in #4165. It rebases the PR and adds a few final tweaks.
Which issue(s) this PR fixes:
Fixes #4162
Does this PR introduce a user-facing change?: