Skip to content

VAP for release v1.5 - #4533

Merged
k8s-ci-robot merged 16 commits into
kubernetes-sigs:mainfrom
robscott:vap-for-release
Feb 13, 2026
Merged

k8s-ci-robot merged 16 commits into
kubernetes-sigs:mainfrom
robscott:vap-for-release

Conversation

@robscott

Copy link
Copy Markdown
Member

What type of PR is this?
/kind feature

What this PR does / why we need it:
This is a follow up to @chris-kaiser's excellent work in #4165. It rebases the PR and adds a few final tweaks.

Which issue(s) this PR fixes:
Fixes #4162

Does this PR introduce a user-facing change?:

Adds a VAP that prohibits the following:
- Installation of experimental CRDs on top of standard channel CRDs (within the same API group)
- Installation of monthly releases
- Installation of older releases

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Feb 13, 2026
@k8s-ci-robot
k8s-ci-robot requested a review from rikatz February 13, 2026 00:59
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 13, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 13, 2026
@robscott robscott mentioned this pull request Feb 13, 2026
@robscott

Copy link
Copy Markdown
Member Author

/cherry-pick release-1.5

@k8s-infra-cherrypick-robot

Copy link
Copy Markdown
Contributor

@robscott: once the present PR merges, I will cherry-pick it on top of release-1.5 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@robscott

Copy link
Copy Markdown
Member Author

/retest

@kflynn

kflynn commented Feb 13, 2026

Copy link
Copy Markdown
Contributor

Looks reasonable from here, thanks @robscott!

/lgtm
/hold for another approval

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 13, 2026
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2026
@youngnick

Copy link
Copy Markdown
Contributor

LGTM from me too.

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 13, 2026
@k8s-ci-robot
k8s-ci-robot merged commit 86cb3b3 into kubernetes-sigs:main Feb 13, 2026
20 of 22 checks passed
@k8s-infra-cherrypick-robot

Copy link
Copy Markdown
Contributor

@robscott: new pull request created: #4534

Details

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@chris-kaiser-7

Copy link
Copy Markdown
Contributor

Hi @robscott Thanks for merging this! I haven't had a chance to check in in a bit so nice to see this merged.

@vast-raymond-page

Copy link
Copy Markdown

Setting the channel to standard on the vap-safeupgrade breaks applying the experimental CRDs to clusters due to the vap-safeguard introspection checks.

danehans pushed a commit to danehans/gateway-api that referenced this pull request Mar 10, 2026
* added vap for experimental crds on standard crds

* tidy

* added validation for older versions

* Update config/crd/standard/gateway.networking.k8s.io_safeUpgradesVAP.yaml

Co-authored-by: Flynn <kflynn@users.noreply.github.com>

* added x-k8s to validation

* tidy

* tidy

* added validation and tidy

* renamed vaps.

* added tests for VAP and tidy

* added resource rules to vap binding.

* added note in RELEASE.md

* removed manadest for modifying existing crd.

* Update tests/crd/crd_test.go

Co-authored-by: Ricardo Pchevuzinske Katz <rikatz@users.noreply.github.com>

* refactored vap tests to seperate package

Signed-off-by: Chris Kaiser <58376705+chris-kaiser-7@users.noreply.github.com>

* A few minor cleanups

---------

Signed-off-by: Chris Kaiser <58376705+chris-kaiser-7@users.noreply.github.com>
Co-authored-by: Christopher Kaiser <58376705+chris-kaiser-7@users.noreply.github.com>
Co-authored-by: Flynn <kflynn@users.noreply.github.com>
Co-authored-by: Ricardo Pchevuzinske Katz <rikatz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VAP for Upgrades

7 participants