Skip to content

cleanup: align types for listener ResolvedRefs condition reason - #4543

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
snorwin:fix-condition-type
Feb 18, 2026
Merged

k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
snorwin:fix-condition-type

Conversation

@snorwin

@snorwin snorwin commented Feb 16, 2026

Copy link
Copy Markdown
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:
This PR aligns the reason types for the ResolvedRefs condition to ensure they use the appropriate ListenerConditionReason type.

Which issue(s) this PR fixes:

N/A

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 16, 2026
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 16, 2026
@snorwin

snorwin commented Feb 16, 2026

Copy link
Copy Markdown
Member Author

/cc @kl52752 @rikatz

@k8s-ci-robot
k8s-ci-robot requested a review from kl52752 February 16, 2026 13:22
@snorwin snorwin changed the title cleanup: align types for lister ResolvedRefs condition reason cleanup: align types for listener ResolvedRefs condition reason Feb 16, 2026
Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>

@kl52752 kl52752 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @snorwin for spotting that!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 17, 2026
@rikatz

rikatz commented Feb 18, 2026

Copy link
Copy Markdown
Member

/approve
/cherry-pick release-1.5

Thanks!

@k8s-infra-cherrypick-robot

Copy link
Copy Markdown
Contributor

@rikatz: once the present PR merges, I will cherry-pick it on top of release-1.5 in a new PR and assign it to you.

Details

In response to this:

/approve
/cherry-pick release-1.5

Thanks!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rikatz, snorwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2026
@k8s-ci-robot
k8s-ci-robot merged commit c153d10 into kubernetes-sigs:main Feb 18, 2026
20 checks passed
@k8s-infra-cherrypick-robot

Copy link
Copy Markdown
Contributor

@rikatz: new pull request created: #4554

Details

In response to this:

/approve
/cherry-pick release-1.5

Thanks!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

danehans pushed a commit to danehans/gateway-api that referenced this pull request Mar 10, 2026
…rnetes-sigs#4543)

Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants