Repository navigation
fix: enable safe-upgrades VAP to permit upgrades of experimental CRDs - #4557
Conversation
|
/cc @robscott |
Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: robscott, snorwin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>
|
Thanks @snorwin! /lgtm |
|
@robscott: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@robscott: #4557 failed to apply on top of branch "release-1.5": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
…kubernetes-sigs#4557) * fix: enable safe-upgrades VAP to permit upgrades of experimental CRDs Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com> * add safe-upgrades VAP tests for experimental CRDs Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com> --------- Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>
What type of PR is this?
/kind bug
What this PR does / why we need it:
The current validation rule prevents upgrades of experimental CRDs. This means that either the validation message is misleading or the expression itself is too restrictive. In my opinion, upgrading experimental CRDs should be allowed without requiring the VAP to be deleted first. Therefore, this PR adjusts the validation expression accordingly.
Which issue(s) this PR fixes:
N/A
Does this PR introduce a user-facing change?: