Skip to content

conformance: tune and allow configuring polling interval - #4570

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
howardjohn:conformance/tune-poll
Feb 24, 2026
Merged

k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
howardjohn:conformance/tune-poll

Conversation

@howardjohn

@howardjohn howardjohn commented Feb 19, 2026 •

Copy link
Copy Markdown
Contributor

Much of the time for conformance is spent waiting on the 1s timer to trigger. These checks are very cheap in-memory checks, so no reason to wait so long. This drops the time down and makes it configurable

What type of PR is this?
/area conformance-machinery

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

The default polling interval for conformance tests has been decreased. This can be modified by the new DefaultPollInterval.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. area/conformance-machinery Issues or PRs related to the machinery and the suite used to run conformance tests. labels Feb 19, 2026
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 19, 2026

@robscott robscott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @howardjohn!

/lgtm
/hold for release note

RequestTimeout: 10 * time.Second,
LatestObservedGenerationSet: 60 * time.Second,
DefaultTestTimeout: 60 * time.Second,
DefaultPollInterval: time.Millisecond * 100,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this decreases the default polling interval for conformance tests 10x, I think we need a release note for this, mind adding one?

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 20, 2026
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 20, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: howardjohn, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Feb 24, 2026
Much of the time for conformance is spent waiting on the 1s timer to
trigger. These checks are very cheap in-memory checks, so no reason to
wait so long. This drops the time down and makes it configurable
@howardjohn
howardjohn force-pushed the conformance/tune-poll branch from fb601bc to 7e4a0e2 Compare February 24, 2026 16:33
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 24, 2026
@howardjohn
howardjohn requested a review from robscott February 24, 2026 16:36
@robscott

Copy link
Copy Markdown
Member

Thanks @howardjohn!

/lgtm
/hold cancel

I'm not sure if we should include this in v1.5 or not, but will make the cherry pick and let @kflynn and/or @bexxmodd decide.

/cherry-pick release-1.5

@k8s-infra-cherrypick-robot

Copy link
Copy Markdown
Contributor

@robscott: once the present PR merges, I will cherry-pick it on top of release-1.5 in a new PR and assign it to you.

Details

In response to this:

Thanks @howardjohn!

/lgtm
/hold cancel

I'm not sure if we should include this in v1.5 or not, but will make the cherry pick and let @kflynn and/or @bexxmodd decide.

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Feb 24, 2026
@k8s-ci-robot
k8s-ci-robot merged commit 542d415 into kubernetes-sigs:main Feb 24, 2026
20 checks passed
@k8s-infra-cherrypick-robot

Copy link
Copy Markdown
Contributor

@robscott: new pull request created: #4599

Details

In response to this:

Thanks @howardjohn!

/lgtm
/hold cancel

I'm not sure if we should include this in v1.5 or not, but will make the cherry pick and let @kflynn and/or @bexxmodd decide.

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

danehans pushed a commit to danehans/gateway-api that referenced this pull request Mar 10, 2026
…sigs#4570)

Much of the time for conformance is spent waiting on the 1s timer to
trigger. These checks are very cheap in-memory checks, so no reason to
wait so long. This drops the time down and makes it configurable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance-machinery Issues or PRs related to the machinery and the suite used to run conformance tests. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants