Repository navigation
conformance: tune and allow configuring polling interval - #4570
Conversation
robscott
left a comment
There was a problem hiding this comment.
Thanks @howardjohn!
/lgtm
/hold for release note
| RequestTimeout: 10 * time.Second, | ||
| LatestObservedGenerationSet: 60 * time.Second, | ||
| DefaultTestTimeout: 60 * time.Second, | ||
| DefaultPollInterval: time.Millisecond * 100, |
There was a problem hiding this comment.
Since this decreases the default polling interval for conformance tests 10x, I think we need a release note for this, mind adding one?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: howardjohn, robscott The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Much of the time for conformance is spent waiting on the 1s timer to trigger. These checks are very cheap in-memory checks, so no reason to wait so long. This drops the time down and makes it configurable
fb601bc to
7e4a0e2
Compare
|
Thanks @howardjohn! /lgtm I'm not sure if we should include this in v1.5 or not, but will make the cherry pick and let @kflynn and/or @bexxmodd decide. /cherry-pick release-1.5 |
|
@robscott: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@robscott: new pull request created: #4599 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
…sigs#4570) Much of the time for conformance is spent waiting on the 1s timer to trigger. These checks are very cheap in-memory checks, so no reason to wait so long. This drops the time down and makes it configurable
Much of the time for conformance is spent waiting on the 1s timer to trigger. These checks are very cheap in-memory checks, so no reason to wait so long. This drops the time down and makes it configurable
What type of PR is this?
/area conformance-machinery
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: