Skip to content

fix: Update listener set programmed conditions - #4586

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
davidjumani:fix-ls-godoc
Feb 23, 2026
Merged

k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
davidjumani:fix-ls-godoc

Conversation

@davidjumani

Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind documentation

What this PR does / why we need it:
This adds the missing ListenersNotValid programmed reason for listenersets, which is enforced in our tests

Which issue(s) this PR fixes:

Fixes #4561

Does this PR introduce a user-facing change?:

Add the missing `ListenersNotValid` programmed reason for listenerSets

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/documentation Categorizes issue or PR as related to documentation. labels Feb 23, 2026
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 23, 2026
@rikatz

rikatz commented Feb 23, 2026

Copy link
Copy Markdown
Member

/lgtm
/approve
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 23, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidjumani, rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 23, 2026
@k8s-ci-robot
k8s-ci-robot merged commit ad2664f into kubernetes-sigs:main Feb 23, 2026
20 checks passed
@robscott

Copy link
Copy Markdown
Member

/cherry-pick release-1.5

@k8s-infra-cherrypick-robot

Copy link
Copy Markdown
Contributor

@robscott: new pull request created: #4589

Details

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ListenerSet v1.5.0: documentation and conformance test misaligned on conditions

5 participants