Repository navigation
grpc: do not require unique hostnames with http - #4598
Conversation
This part of the spec is not implemented by a large number of implementations. That I know of: * Istio * Kgateway * Envoy Gateway * Contour * Agentgateway I can only speak for the ones I am involved in, but this is not an accident; this was an intentional diversion from the recommendation here, as this does not meet users needs. HTTP and gRPC are entirely compatible to be on the same hostname, and quite common to do so even if the gRPC maintainers does not consider it a best practice (I am not sure how this is even true, given this opinion comes from Google who hosts HTTP and gRPC on the same `googleapis.com`?? maybe I am missing something). Instead, this forces users into an arbitrary restriction and then forces them to rewrite all of their routes from GRPCRoute to HTTPRoute which is a regression in usability. The original GEP: ``` If at some point in the future, demand for this use case increases and we have reason to believe that the feasibility of implementation has improved, this would be a backward compatible change. ``` Given the reality of the current state of implementations, I believe the demand for this has been met to change the spec. See also https://kubernetes.slack.com/archives/CR0H13KGA/p1770320071586889
| Implementations that support GRPCRoute may enforce uniqueness of | ||
| hostnames between `GRPCRoute`s and `HTTPRoute`s. That is, if a route (A) of type `HTTPRoute` or |
There was a problem hiding this comment.
As the uniqueness is not currently enforced within a Route type (as raised in #4303), this relaxation seems reasonable to me and could be tightened again in the future.
|
yeah, I agree with this as well. It is desired to not mix the hostnames on HTTPRoute and GRPCRoute, but it is not like this needs an enforcement. /approve @snorwin leaving the lgtm for you. Thanks @howardjohn |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: howardjohn, rikatz, snorwin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This part of the spec is not implemented by a large number of implementations. That I know of:
I can only speak for the ones I am involved in, but this is not an accident; this was an intentional diversion from the recommendation here, as this does not meet users needs. HTTP and gRPC are entirely compatible to be on the same hostname, and quite common to do so even if the gRPC maintainers does not consider it a best practice (I am not sure how this is even true, given this opinion comes from Google who hosts HTTP and gRPC on the same
googleapis.com?? maybe I am missing something). Instead, this forces users into an arbitrary restriction and then forces them to rewrite all of their routes from GRPCRoute to HTTPRoute which is a regression in usability.The original GEP:
Given the reality of the current state of implementations, I believe the demand for this has been met to change the spec.
See also https://kubernetes.slack.com/archives/CR0H13KGA/p1770320071586889
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: