Skip to content

safe-upgrade: allow installing experimental when no current CRD is in… - #4603

Merged
k8s-ci-robot merged 2 commits into
kubernetes-sigs:mainfrom
howardjohn:vap/allow-install-when-empty
Feb 26, 2026
Merged

k8s-ci-robot merged 2 commits into
kubernetes-sigs:mainfrom
howardjohn:vap/allow-install-when-empty

Conversation

@howardjohn

@howardjohn howardjohn commented Feb 25, 2026 •

Copy link
Copy Markdown
Contributor

…stalled

What type of PR is this?

/kind bug
What this PR does / why we need it:

Otherwise its impossible to install the experimental CRD at all (aside from getting lucky and racing the API server).

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Fixed an issue where the ValidatingAdmissionPolicy prevented experimental CRDs from being installed at all (instead of only when standard CRDs already exist).

…stalled

Otherwise its impossible to install the experimental CRD at all (aside
from getting lucky and racing the API server).
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 25, 2026
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 25, 2026
@kflynn

kflynn commented Feb 25, 2026

Copy link
Copy Markdown
Contributor

/approve
/hold for maintainer review

Leaving the final LGTM for a maintainer

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 25, 2026
@davidjumani

Copy link
Copy Markdown
Contributor

/approve
nit: I'd prefer the test not have an exact match for the CRDs as it will need updating whenever a new CRD is added or promoted

@robscott

Copy link
Copy Markdown
Member

I'd prefer the test not have an exact match for the CRDs as it will need updating whenever a new CRD is added or promoted

+1, not a blocker, but would be nice. Will leave hold in place for a bit in case @howardjohn has time to update.

/cherry-pick release-1.5
/approve
/lgtm

@k8s-infra-cherrypick-robot

Copy link
Copy Markdown
Contributor

@robscott: once the present PR merges, I will cherry-pick it on top of release-1.5 in a new PR and assign it to you.

Details

In response to this:

I'd prefer the test not have an exact match for the CRDs as it will need updating whenever a new CRD is added or promoted

+1, not a blocker, but would be nice. Will leave hold in place for a bit in case @howardjohn has time to update.

/cherry-pick release-1.5
/approve
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 26, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidjumani, howardjohn, kflynn, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2026
@youngnick

Copy link
Copy Markdown
Contributor

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 26, 2026
@k8s-ci-robot
k8s-ci-robot merged commit 1c39c4b into kubernetes-sigs:main Feb 26, 2026
31 of 32 checks passed
@k8s-infra-cherrypick-robot

Copy link
Copy Markdown
Contributor

@robscott: new pull request created: #4604

Details

In response to this:

I'd prefer the test not have an exact match for the CRDs as it will need updating whenever a new CRD is added or promoted

+1, not a blocker, but would be nice. Will leave hold in place for a bit in case @howardjohn has time to update.

/cherry-pick release-1.5
/approve
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

danehans pushed a commit to danehans/gateway-api that referenced this pull request Mar 10, 2026
kubernetes-sigs#4603)

* safe-upgrade: allow installing experimental when no current CRD is installed

Otherwise its impossible to install the experimental CRD at all (aside
from getting lucky and racing the API server).

* Update tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants