Skip to content

tlsroute: allow FIN or RST instead of just RST - #4615

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
howardjohn:conformance/tls-route-allow-fin
Mar 1, 2026
Merged

k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
howardjohn:conformance/tls-route-allow-fin

Conversation

@howardjohn

Copy link
Copy Markdown
Contributor

What type of PR is this?

/area conformance-test

What this PR does / why we need it:
Which one is used is not part of the spec, and if it was I don't think RST is the right behavior generally anyways and FIN is preferred.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Updated the TLSRoute conformance tests to allow FINs where previously RST was asserted

Which one is used is not part of the spec, and if it was I don't think
RST is the right behavior generally anyways and FIN is preferred.
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/conformance-test Issues or PRs related to Conformance tests. labels Feb 27, 2026
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 27, 2026
@rikatz

rikatz commented Mar 1, 2026

Copy link
Copy Markdown
Member

/lgtm
/approve

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 1, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: howardjohn, rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rikatz

rikatz commented Mar 1, 2026

Copy link
Copy Markdown
Member

/retest

@rikatz

rikatz commented Mar 1, 2026

Copy link
Copy Markdown
Member

/test pull-gateway-api-verify

@k8s-ci-robot
k8s-ci-robot merged commit 6b9e4b5 into kubernetes-sigs:main Mar 1, 2026
20 checks passed
@howardjohn

Copy link
Copy Markdown
Contributor Author

/cherrypick release-1.5

@k8s-infra-cherrypick-robot

Copy link
Copy Markdown
Contributor

@howardjohn: new pull request created: #4624

Details

In response to this:

/cherrypick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

danehans pushed a commit to danehans/gateway-api that referenced this pull request Mar 10, 2026
Which one is used is not part of the spec, and if it was I don't think
RST is the right behavior generally anyways and FIN is preferred.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance-test Issues or PRs related to Conformance tests. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants