Skip to content

cleanup: fix docs build variable mismatch and script error handling - #4616

Merged
k8s-ci-robot merged 2 commits into
kubernetes-sigs:mainfrom
samzong:fix/docs-build-scripts
May 15, 2026
Merged

k8s-ci-robot merged 2 commits into
kubernetes-sigs:mainfrom
samzong:fix/docs-build-scripts

Conversation

@samzong

@samzong samzong commented Feb 28, 2026

Copy link
Copy Markdown
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Fix docs build tooling bugs.

  • VALIDATE_DOCS_EXTRA_ARGS in verify-docs target doesn't match the VALIDATE_DOCS_EXTRA_FLAGS variable definition.
  • generate.sh uses git checkout --work-tree which pollutes the repository index, replaced with git archive | tar.

Which issue(s) this PR fixes:

NONE

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Feb 28, 2026
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 28, 2026
Comment thread hack/mkdocs/generate.sh Resolved
@rikatz

rikatz commented May 11, 2026

Copy link
Copy Markdown
Member

@samzong will you be able to do my proposed changes?

Thanks

@samzong

samzong commented May 12, 2026

Copy link
Copy Markdown
Member Author

@rikatz Sorry, I missed your message earlier. The suggested changes have been applied. Thanks!

@rikatz

rikatz commented May 15, 2026

Copy link
Copy Markdown
Member

@samzong can you please rebase? we moved away from mkdocs to hugo/docsy and the proposal may have to change a bit here.

Thanks!

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 15, 2026
samzong and others added 2 commits May 15, 2026 23:54
Signed-off-by: samzong <samzong.lu@gmail.com>
Co-authored-by: Ricardo Pchevuzinske Katz <7182341+rikatz@users.noreply.github.com>
Signed-off-by: samzong <samzong.lu@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 15, 2026
@samzong

samzong commented May 15, 2026

Copy link
Copy Markdown
Member Author

@rikatz done

@rikatz

rikatz commented May 15, 2026

Copy link
Copy Markdown
Member

thank you!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 15, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rikatz, samzong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2026
@k8s-ci-robot
k8s-ci-robot merged commit 6bfe314 into kubernetes-sigs:main May 15, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants