Skip to content

fix: use JoinHostPort - #4636

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
zirain-dev:use-JoinHostPort
Mar 5, 2026
Merged

k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
zirain-dev:use-JoinHostPort

Conversation

@zirain

@zirain zirain commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

What type of PR is this?

/area conformance-test
/kind bug

What this PR does / why we need it:

Similar to #4629, I missed these in #4629.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

fix GatewayFrontendClientCertificateValidationInsecureFallback/GatewayFrontendClientCertificateValidation/GatewayFrontendInvalidDefaultClientCertificateValidation on IPv6 cluster. 

Signed-off-by: zirain <zirain2009@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/conformance-test Issues or PRs related to Conformance tests. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 4, 2026
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 4, 2026
@zirain

zirain commented Mar 4, 2026

Copy link
Copy Markdown
Contributor Author

cc @youngnick @rikatz

@zirain

zirain commented Mar 4, 2026

Copy link
Copy Markdown
Contributor Author

/retest

@rikatz

rikatz commented Mar 5, 2026

Copy link
Copy Markdown
Member

/lgtm
/approve
thanks. does this needs to be cherry-picked?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 5, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rikatz, zirain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2026
@k8s-ci-robot
k8s-ci-robot merged commit e51f71a into kubernetes-sigs:main Mar 5, 2026
20 checks passed
@zirain

zirain commented Mar 6, 2026

Copy link
Copy Markdown
Contributor Author

@rikatz I think we need to cherrypick.

@zirain
zirain deleted the use-JoinHostPort branch March 6, 2026 00:03
@rikatz

rikatz commented Mar 6, 2026

Copy link
Copy Markdown
Member

/cherry-pick release-1.5

@k8s-infra-cherrypick-robot

Copy link
Copy Markdown
Contributor

@rikatz: #4636 failed to apply on top of branch "release-1.5":

Applying: fix: use JoinHostPort
Using index info to reconstruct a base tree...
M	conformance/tests/gateway-invalid-default-frontend-client-certificate-validation.go
Falling back to patching base and 3-way merge...
Auto-merging conformance/tests/gateway-invalid-default-frontend-client-certificate-validation.go
CONFLICT (content): Merge conflict in conformance/tests/gateway-invalid-default-frontend-client-certificate-validation.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 fix: use JoinHostPort

Details

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

zirain added a commit to zirain-dev/gateway-api that referenced this pull request Mar 6, 2026
Signed-off-by: zirain <zirain2009@gmail.com>
@rikatz

rikatz commented Mar 6, 2026

Copy link
Copy Markdown
Member

@zirain do you mind manually cherry-picking and sending me the PR? (ping me on Slack). I am a bit swamped here now

@zirain

zirain commented Mar 6, 2026

Copy link
Copy Markdown
Contributor Author

@zirain do you mind manually cherry-picking and sending me the PR? (ping me on Slack). I am a bit swamped here now

#4646

k8s-ci-robot pushed a commit that referenced this pull request Mar 9, 2026
* fix: use JoinHostPort (#4636)

Signed-off-by: zirain <zirain2009@gmail.com>

* Update conformance/tests/gateway-invalid-default-frontend-client-certificate-validation.go

Co-authored-by: Mike Morris <mikemorris@users.noreply.github.com>

---------

Signed-off-by: zirain <zirain2009@gmail.com>
Co-authored-by: Mike Morris <mikemorris@users.noreply.github.com>
danehans pushed a commit to danehans/gateway-api that referenced this pull request Mar 10, 2026
Signed-off-by: zirain <zirain2009@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance-test Issues or PRs related to Conformance tests. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants