Repository navigation
fix: use JoinHostPort - #4636
Conversation
Signed-off-by: zirain <zirain2009@gmail.com>
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rikatz, zirain The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@rikatz I think we need to cherrypick. |
|
/cherry-pick release-1.5 |
|
@rikatz: #4636 failed to apply on top of branch "release-1.5": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: zirain <zirain2009@gmail.com>
|
@zirain do you mind manually cherry-picking and sending me the PR? (ping me on Slack). I am a bit swamped here now |
* fix: use JoinHostPort (#4636) Signed-off-by: zirain <zirain2009@gmail.com> * Update conformance/tests/gateway-invalid-default-frontend-client-certificate-validation.go Co-authored-by: Mike Morris <mikemorris@users.noreply.github.com> --------- Signed-off-by: zirain <zirain2009@gmail.com> Co-authored-by: Mike Morris <mikemorris@users.noreply.github.com>
Signed-off-by: zirain <zirain2009@gmail.com>
What type of PR is this?
/area conformance-test
/kind bug
What this PR does / why we need it:
Similar to #4629, I missed these in #4629.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: