Skip to content

update ListenerConditionConflicted condition docs - #4659

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
davidjumani:update-conflicted-status
Mar 10, 2026
Merged

k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
davidjumani:update-conflicted-status

Conversation

@davidjumani

Copy link
Copy Markdown
Contributor

What type of PR is this?

Add one of the following kinds:
/kind cleanup

What this PR does / why we need it:
This PR aligns the ListenerConditionConflicted condition as discussed in #4618

Updates the documentation around the ListenerConditionConflicted condition 

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Mar 10, 2026
@k8s-ci-robot
k8s-ci-robot requested a review from candita March 10, 2026 16:08
@k8s-ci-robot k8s-ci-robot added the kind/gep PRs related to Gateway Enhancement Proposal(GEP) label Mar 10, 2026
@k8s-ci-robot
k8s-ci-robot requested a review from youngnick March 10, 2026 16:08
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 10, 2026
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 10, 2026
@rikatz

rikatz commented Mar 10, 2026

Copy link
Copy Markdown
Member

@davidjumani I guess you need to run "make generate"

@rikatz

rikatz commented Mar 10, 2026

Copy link
Copy Markdown
Member

actually nevermind, this is just a comment on a const
/lgtm
/approve
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidjumani, rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2026
@rikatz

rikatz commented Mar 10, 2026

Copy link
Copy Markdown
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 10, 2026
@k8s-ci-robot
k8s-ci-robot merged commit 008d0f9 into kubernetes-sigs:main Mar 10, 2026
20 checks passed
danehans pushed a commit to danehans/gateway-api that referenced this pull request Mar 10, 2026
@davidjumani

Copy link
Copy Markdown
Contributor Author

/cherrypick release-1.5

@k8s-infra-cherrypick-robot

Copy link
Copy Markdown
Contributor

@davidjumani: new pull request created: #4669

Details

In response to this:

/cherrypick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/gep PRs related to Gateway Enhancement Proposal(GEP) lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants