Skip to content

limit HTTPRouteHTTPSListenerDetectMisdirectedRequests to h2 only - #4665

Merged
k8s-ci-robot merged 2 commits into
kubernetes-sigs:mainfrom
zirain-dev:misdirected-requests
Mar 11, 2026
Merged

k8s-ci-robot merged 2 commits into
kubernetes-sigs:mainfrom
zirain-dev:misdirected-requests

Conversation

@zirain

@zirain zirain commented Mar 11, 2026

Copy link
Copy Markdown
Contributor

What type of PR is this?

/area conformance-test
/kind bug

What this PR does / why we need it:

As discussed here, this should be limited to h2 only.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

limit HTTPRouteHTTPSListenerDetectMisdirectedRequests to h2 only

cc @snorwin

Signed-off-by: zirain <zirain2009@gmail.com>
@k8s-ci-robot k8s-ci-robot added area/conformance-test Issues or PRs related to Conformance tests. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Mar 11, 2026
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 11, 2026
@zirain

zirain commented Mar 11, 2026

Copy link
Copy Markdown
Contributor Author

/cherry-pick release-1.5

@k8s-infra-cherrypick-robot

Copy link
Copy Markdown
Contributor

@zirain: once the present PR merges, I will cherry-pick it on top of release-1.5 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@zirain

zirain commented Mar 11, 2026

Copy link
Copy Markdown
Contributor Author

/retest

Signed-off-by: zirain <zirain2009@gmail.com>
@youngnick

Copy link
Copy Markdown
Contributor

Thanks for this @zirain.

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2026

@snorwin snorwin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zirain!

I was able to successfully run the HTTPRouteHTTPSListenerDetectMisdirectedRequests conformance test with the Airlock Microgateway.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 11, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: snorwin, youngnick, zirain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
k8s-ci-robot merged commit d143f3b into kubernetes-sigs:main Mar 11, 2026
20 checks passed
@k8s-infra-cherrypick-robot

Copy link
Copy Markdown
Contributor

@zirain: #4665 failed to apply on top of branch "release-1.5":

Applying: limit HTTPRouteHTTPSListenerDetectMisdirectedRequests to h2 only
Using index info to reconstruct a base tree...
M	conformance/tests/httproute-https-listener-detect-misdirected-requests.go
Falling back to patching base and 3-way merge...
Auto-merging conformance/tests/httproute-https-listener-detect-misdirected-requests.go
Applying: fix lint
Using index info to reconstruct a base tree...
M	conformance/tests/httproute-https-listener-detect-misdirected-requests.go
Falling back to patching base and 3-way merge...
Auto-merging conformance/tests/httproute-https-listener-detect-misdirected-requests.go
CONFLICT (content): Merge conflict in conformance/tests/httproute-https-listener-detect-misdirected-requests.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0002 fix lint

Details

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

zirain added a commit to zirain-dev/gateway-api that referenced this pull request Mar 11, 2026
…ernetes-sigs#4665)

* limit HTTPRouteHTTPSListenerDetectMisdirectedRequests to h2 only

Signed-off-by: zirain <zirain2009@gmail.com>

* fix lint

Signed-off-by: zirain <zirain2009@gmail.com>

---------

Signed-off-by: zirain <zirain2009@gmail.com>
k8s-ci-robot pushed a commit that referenced this pull request Mar 12, 2026
…) (#4667)

* limit HTTPRouteHTTPSListenerDetectMisdirectedRequests to h2 only



* fix lint



---------

Signed-off-by: zirain <zirain2009@gmail.com>
@zirain
zirain deleted the misdirected-requests branch June 16, 2026 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance-test Issues or PRs related to Conformance tests. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants