Repository navigation
docs: clarify RequestHeaderModifier set behavior - #4684
Conversation
Signed-off-by: Shaanveer Singh <shaanver.singh@gmail.com>
|
Welcome @ShaanveerS! |
|
Hi @ShaanveerS. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Thanks! |
|
Thanks, @ShaanveerS! Looks good from here. /ok-to-test |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mikemorris, ShaanveerS The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Shaanveer Singh <shaanver.singh@gmail.com>
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Clarifies the
RequestHeaderModifierguide to match the documented behavior ofset, as agreed in #3314 (comment)Which issue(s) this PR fixes:
Fixes #3314
Does this PR introduce a user-facing change?: