Skip to content

docs: clarify RequestHeaderModifier set behavior - #4684

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
ShaanveerS:3314-set-docs
Apr 17, 2026
Merged

k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
ShaanveerS:3314-set-docs

Conversation

@ShaanveerS

Copy link
Copy Markdown
Member

What type of PR is this?

/kind documentation

What this PR does / why we need it:
Clarifies the RequestHeaderModifier guide to match the documented behavior of set, as agreed in #3314 (comment)

Which issue(s) this PR fixes:

Fixes #3314

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Shaanveer Singh <shaanver.singh@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 13, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Welcome @ShaanveerS!

It looks like this is your first PR to kubernetes-sigs/gateway-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/gateway-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 13, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Hi @ShaanveerS. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@FredrikAugust

Copy link
Copy Markdown

Thanks!

@kflynn

kflynn commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

Thanks, @ShaanveerS! Looks good from here.

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 17, 2026
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 17, 2026
@mikemorris

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikemorris, ShaanveerS

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2026
@k8s-ci-robot
k8s-ci-robot merged commit 3d84e6d into kubernetes-sigs:main Apr 17, 2026
8 checks passed
ericdbishop pushed a commit to ericdbishop/gateway-api that referenced this pull request Apr 22, 2026
Signed-off-by: Shaanveer Singh <shaanver.singh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clarify documentation of RequestHeaderModifier .set and .add behaviour

5 participants