Skip to content

2734 - update gateway infrastructure annotations to 16 - #4707

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
wenisman:2734_gateway_annotations_increase
Mar 21, 2026
Merged

k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
wenisman:2734_gateway_annotations_increase

Conversation

@wenisman

@wenisman wenisman commented Mar 21, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #2734

/kind feature

What this PR does / why we need it:
update to increase the number of annotations within the gateway infrastructure to 16.
When using the AWS LoadBalancerController there are a number of annotations that must be applied when the LoadBalancer is created, adding the annotations after the load balancer is created (or the request to create the LoadBalancer is sent results in the changes not being applied). Such changes are the Subnets to be attached, SSL Policy, scheme and a number of others. You will often find that you reach the limit of 8 annotations on the infrastructure very quickly, applying the annotations through the config map is too late and the changes wont be applied. This is more a sequencing issue with the LoadBalanceController however until AWS upgrades how this works we require a way to create the NLB with our specified requirements.

Which issue(s) this PR fixes:
Fixes #2734

Does this PR introduce a user-facing change?:

Yes, it will allow the usage of up to 16 annotations on the gateway infrastructure object.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Mar 21, 2026
@linux-foundation-easycla

linux-foundation-easycla Bot commented Mar 21, 2026 •

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: wenisman / name: Geoffrey Tsai (4d74311)

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Welcome @wenisman!

It looks like this is your first PR to kubernetes-sigs/gateway-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/gateway-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 21, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Hi @wenisman. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@wenisman wenisman changed the title 2734 … 2734 - update gateway infrastructure annotations to 16 Mar 21, 2026
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 21, 2026
@youngnick

Copy link
Copy Markdown
Contributor

Thanks for this @wenisman.

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2026
@rikatz

rikatz commented Mar 21, 2026

Copy link
Copy Markdown
Member

/ok-to-test
/lgtm
/approve
/hold cancel
Thank you!

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 21, 2026
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 21, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rikatz, wenisman, youngnick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
k8s-ci-robot merged commit 3141ca9 into kubernetes-sigs:main Mar 21, 2026
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Increase Gateway CRD Infrastructure Annotation Limit

4 participants