Repository navigation
2734 - update gateway infrastructure annotations to 16 - #4707
k8s-ci-robot merged 1 commit into
Conversation
|
|
|
Welcome @wenisman! |
|
Hi @wenisman. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Thanks for this @wenisman. /approve |
|
/ok-to-test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rikatz, wenisman, youngnick The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #2734
/kind feature
What this PR does / why we need it:
update to increase the number of annotations within the gateway infrastructure to 16.
When using the AWS LoadBalancerController there are a number of annotations that must be applied when the LoadBalancer is created, adding the annotations after the load balancer is created (or the request to create the LoadBalancer is sent results in the changes not being applied). Such changes are the Subnets to be attached, SSL Policy, scheme and a number of others. You will often find that you reach the limit of 8 annotations on the infrastructure very quickly, applying the annotations through the config map is too late and the changes wont be applied. This is more a sequencing issue with the LoadBalanceController however until AWS upgrades how this works we require a way to create the NLB with our specified requirements.
Which issue(s) this PR fixes:
Fixes #2734
Does this PR introduce a user-facing change?: