Skip to content

generator: omit top-level CRD status from manifests - #4712

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
MatteoFari:fix-4402-crd-status-manifests
Apr 7, 2026
Merged

k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
MatteoFari:fix-4402-crd-status-manifests

Conversation

@MatteoFari

Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:
This PR fixes how CRD files are generated.

Right now, the generated install YAML includes a top-level status field in CustomResourceDefinition objects. That field contains invalid null values, which causes tools like kubeconform to fail. Since status is filled in by Kubernetes, it should not be in static install files.

This change removes that field from generated manifests and regenerates the CRDs.

Which issue(s) this PR fixes:

Fixes #4402

Does this PR introduce a user-facing change?:

Generated Gateway API CRD install manifests no longer include top-level CustomResourceDefinition status fields with invalid null values, fixing strict schema validation failures in tools such as kubeconform.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Mar 24, 2026
@k8s-ci-robot
k8s-ci-robot requested review from rikatz and robscott March 24, 2026 10:11
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Welcome @MatteoFari!

It looks like this is your first PR to kubernetes-sigs/gateway-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/gateway-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 24, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Hi @MatteoFari. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 24, 2026
@youngnick

Copy link
Copy Markdown
Contributor

Sure, this seems fine to me.

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2026
Comment thread tools/generator/main.go Resolved
@rikatz

rikatz commented Apr 6, 2026

Copy link
Copy Markdown
Member

/ok-to-test
One minor comment, otherwise lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 6, 2026
Signed-off-by: Matteo Fari <matteofari06@gmail.com>
@MatteoFari
MatteoFari force-pushed the fix-4402-crd-status-manifests branch from 89805b4 to 9b71abe Compare April 7, 2026 09:46

@rikatz rikatz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 7, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MatteoFari, rikatz, youngnick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
k8s-ci-robot merged commit 61a46b7 into kubernetes-sigs:main Apr 7, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Standard CRD manifests contain invalid null values in .status fields, breaking schema validation

4 participants