Repository navigation
generator: omit top-level CRD status from manifests - #4712
Conversation
|
Welcome @MatteoFari! |
|
Hi @MatteoFari. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Sure, this seems fine to me. /approve |
|
/ok-to-test |
Signed-off-by: Matteo Fari <matteofari06@gmail.com>
89805b4 to
9b71abe
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MatteoFari, rikatz, youngnick The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR fixes how CRD files are generated.
Right now, the generated install YAML includes a top-level
statusfield inCustomResourceDefinitionobjects. That field contains invalidnullvalues, which causes tools likekubeconformto fail. Sincestatusis filled in by Kubernetes, it should not be in static install files.This change removes that field from generated manifests and regenerates the CRDs.
Which issue(s) this PR fixes:
Fixes #4402
Does this PR introduce a user-facing change?: