Skip to content

start using images from registry.k8s.io - #4728

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
upodroid:fix-image-registries
Apr 13, 2026
Merged

k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
upodroid:fix-image-registries

Conversation

@upodroid

@upodroid upodroid commented Apr 3, 2026 •

Copy link
Copy Markdown
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

All end-user facing images need to be served from registry.k8s.io, you can't serve any images hosted at gcr.io/k8-staging-* or us-central1-docker.pkg.dev/k8s-staging-images/* to end users. The project has a policy for serving docker images to end users here.

Unfortunately, we got hit with a large bill, and we need to shut down gcr.io/k8s-staging-gateway-api as soon as possible. To do that:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 3, 2026
@k8s-ci-robot
k8s-ci-robot requested review from candita and robscott April 3, 2026 13:10
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 3, 2026
Comment thread conformance/base/manifests.yaml Resolved
Comment thread conformance/mesh/manifests.yaml Resolved
@rikatz

rikatz commented Apr 6, 2026

Copy link
Copy Markdown
Member

@upodroid

upodroid commented Apr 6, 2026

Copy link
Copy Markdown
Member Author

Before I backfill the images, I asked this question on Slack

whats the difference between echo-basic and echo-advanced? Also, echo-advanced is a copy of the istio app image which hasn't been updated in a long time

https://kubernetes.slack.com/archives/CR0H13KGA/p1775222564804039?thread_ts=1775079862.624539&cid=CR0H13KGA

@youngnick

Copy link
Copy Markdown
Contributor

echo-basic is for the north-south tests, while echo-advanced is for east-west mesh cases. You're correct that's it's a copy of the istio app image, the reason to do that was to move the the test artifact under Gateway API's control, rather than being under Istio's control. That way, the Gateway API conformance tests are not dependent on another organization's binary.

allowedRoutes:
namespaces:
from: Same
- name: http

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering why the whitespace changes weren't caught by the linter. Could you fix them anyway?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's supposed to be indented by 2 spaces.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes you are right, it seems we mixed things up, in the conformance tests we do indent with two spaces, but in the examples we don't. Maybe we should harmonize this at some point, but I'm fine with it for now.

@upodroid

upodroid commented Apr 12, 2026 •

Copy link
Copy Markdown
Member Author

This is ready to be merged, all the images have been promoted to registry.k8s.io, including 1.4 and 1.5

@snorwin snorwin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @upodroid.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 12, 2026
@youngnick

Copy link
Copy Markdown
Contributor

/approve

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: snorwin, upodroid, youngnick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 13, 2026
@k8s-ci-robot
k8s-ci-robot merged commit b9c792c into kubernetes-sigs:main Apr 13, 2026
32 checks passed
@upodroid

Copy link
Copy Markdown
Member Author

We also need to merge this test-infra PR.

kubernetes/test-infra#36762

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants