Repository navigation
Provisional: Endpointselector GEP - #4731
keithmattix wants to merge 6 commits into
Conversation
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
|
Skipping CI for Draft Pull Request. |
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: keithmattix The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
|
|
||
| There are two main interfaces that will trigger the creation of an `EndpointSelector`: | ||
|
|
||
| 1. When a user manually creates an `EndpointSelector` resource. In this case, the user opts-in to managing the lifecycle of the resource (e.g. nothing will set ownerReferences). Most of the time, users will choose this UX when wanting to decorate an existing `Service` with context or functionality described in a higher-level resource (e.g. `Backend` type `EndpointSelector` (TODO: confirm naming once `Backend` GEP is finalized)). These resources would reference the `EndpointSelector` via an object reference field in their spec. CRDs that utilize this pattern SHOULD add status to their APIs to report the validity of the reference. |
There was a problem hiding this comment.
do we expect the endpointselector to be also supported as a backendRef? Let's say today we already support it via InferencePool, and as I can see below we say that an endpointSelector will be created by it, but given a scenario I want to create it manually, and say "my backends should be acquired from this endpointSelector" instead of relying on inferencePool, would we support it?
Do we envision also something like an union feature with backendTLSPolicy, where we apply a policy to the selected endpoints?
There was a problem hiding this comment.
Good question; I know @LiorLieberman was thinking about EndpointSelector as a backendRef, but I honestly struggle to think of a scenario where you wouldn't want a Backend (or some higher level resource) to generate an EndpointSelector. Same goes for TLS and policy attachment. It may/probably exists and I just can't think of it.
There was a problem hiding this comment.
I agree that it doesn't seem like there's any reason why EndpointSelector as a backendRef would not work, but also, there doesn't seem to be a compelling reason why you would use it when you had Backend, InferencePool, or similar wrapper.
There was a problem hiding this comment.
Maybe another way to think about this is: if EndpointSelector does end up in upstream, would we allow it as a backendRef? Again, it doesn't seem like the best option, but there's no reason why it wouldn't work.
|
I think there is interest to make this not just an Gateway API resource but to bring this into Core? I think it would good to discuss this at the main SIG Network meeting. |
|
@bowei yes the plan is to have a two timelines approach to make this a KEP as well as a GEP |
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
|
Is the point that this EndpointSelector would generate EndpointSlice(s) ? |
|
@thockin yup exactly. To start, we'd have gateway implementations do it, but the design is meant to be scoped enough to where endpointslice-controller can do it without adding a ton of complexity. |
youngnick
left a comment
There was a problem hiding this comment.
I think frontrunning the upstream KEP like this is actually a pretty great idea, especially in Experimental. Whether this should move to Standard later will be a more interesting conversation.
It worked out well for ReferenceGrant. /s |
Signed-off-by: Keith Mattix II <keithmattix2@gmail.com>
|
Thanks for putting this together. I think the current proposal address two different problems:
Is there any reason to not follow the existing relational model? it seems easier to think about to me
strongly agree |
|
fair, I just wanted to be sure we can support existing Services ... Thanks |
One detail that's not in here that will be in the KEP is that we want Service controller to create (the in-tree version of) an EndpointSelector for compatibility (just like what you did with IPAddress) |
Yeah, IIUIC the plan is to get XEndpointSelector to work and socialize and get the things working, and then will have the discussion to move to Gateway or directly to core, optimistically we move to core , is that the plan? |
|
@aojea depends on when 1.37 KEP freeze is 😅 if it's still possible to get a KEP accepted for that, I can work on something so that we're not head of line blocking on Gateway |
I do not understand, first you need to get XEndpointSelector implemented and working and then later we evoluate the next steps, the KEP goes after not first ... so I took you are aiming for 1.38 |
|
The plan I talked about with @LiorLieberman @robscott and others about is trying to do it at the same time so we don't lose 4 months on the KEP process. We were also hoping the implementation could live in the endpointslice controller so that implementations can just import the functionality without manually dealing with endpoints. |
I do not understand exactly what are you proposing and the technical details, you need to be more specific |
|
Part of #4914 |
Signed-off-by: Keith Mattix II <keithmattix2@gmail.com>
|
Because we are discussing here a kind of pre-alpha core object: Can we have a "kind" based filter in the selector? |
|
@szuecs I don't think we can include a kind since endpointslice-controller is going to be the component that is creating EndpointSlices and it's strictly coupled to pods (for good reason since EndpointSlice expects certain information) |
Domage! 😊 |
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
There was a problem hiding this comment.
there was some discussion at kubecon to turn this into memorandum GEP.
In the backend GEP, I've added a section on the stop gap service-backing & future KEP.
Is there any reason we need this GEP? Is the current backend GEP missing any context that turning this into a memorandum would still be needed?
There was a problem hiding this comment.
If it's in Backend already, we can probably just kill this GEP
There was a problem hiding this comment.
Yes, we can just mark this as Declined. Still worthwhile merging it as Declined, maybe? To preserve that we discussed it?
This PR introduces a new
EndpointSelectorresource that allows implementations to get a "back of endpoints" for any number of pods matching a workload selector. As explained in the text, this GEP is an expedient measure meant to give us time to iterate and get feedback while an analogous KEP percolates through the upstream Kubernetes process. This resource should not progress past experimental