Repository navigation
conformance: make weight test 100x faster - #4740
Merged
Merged
Conversation
The current test takes 17s due to randomly injected sleep across 500 requests. This happens twice (HTTP and GRPC) for a total of 34s for these 2 tests. With this PR, the test takes <1s for me. For context, our entire e2e suite outside of gateway-api conformance takes 27s, so this 1 test is more than doubling our test times. The original context for this was kubernetes-sigs#3827 (comment). I don't think this is needed for the test; if an implementation requires the entropy to properly distribute weight then it is broken and *should* fail. And I am not sure of any possible implementation that would only work *with* entropy; however, I did leave the randomized payload part of the suggestion (the original suggestion was to add *something* not necesarily sleeping).
Contributor
Author
|
/assign @LiorLieberman |
snorwin
reviewed
Apr 14, 2026
snorwin
left a comment
Member
There was a problem hiding this comment.
@howardjohn thanks, just added a small nit.
Comment on lines
213
to
215
| // AddRandomEntropy randomly chooses to add delay, random value, or both | ||
| // The addRandomValue function should be provided by the caller to handle | ||
| // protocol-specific ways of adding the random value (HTTP headers, gRPC metadata, etc.) |
Member
There was a problem hiding this comment.
nit: the description here should be updated as well
Member
|
/release-note-none |
howardjohn
commented
Apr 14, 2026
snorwin
approved these changes
Apr 15, 2026
snorwin
left a comment
Member
There was a problem hiding this comment.
@howardjohn thanks a lot.
/lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: howardjohn, snorwin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/area conformance-machinery
What this PR does / why we need it:
The current test takes 17s due to randomly injected sleep across 500 requests. This happens twice (HTTP and GRPC) for a total of 34s for these 2 tests.
With this PR, the test takes <1s for me.
For context, our entire e2e suite outside of gateway-api conformance takes 27s, so this 1 test is more than doubling our test times.
The original context for this was
#3827 (comment). I don't think this is needed for the test; if an implementation requires the entropy to properly distribute weight then it is broken and should fail. And I am not sure of any possible implementation that would only work with entropy; however, I did leave the randomized payload part of the suggestion (the original suggestion was to add something not necesarily sleeping).
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: