Repository navigation
conformance: Add tests for omitted and empty backendRefs - #4750
Conversation
|
Welcome @optix2000! |
|
Hi @optix2000. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@optix2000, did you also open an issue on the implementation's repository to let them know about this problem? |
|
/ok-to-test |
Lets just say that they don't agree it's a problem because the comformance tests pass. |
|
|
|
/retest |
|
FWIW I had a bug this exact test would have caught (a while ago) and was surprised it wasn't covered. So 👍 from me |
|
I agree, we mandate this behavior, we should test it. /approve |
The behavior is explicitly specified, but some controllers do not conform.
snorwin
left a comment
There was a problem hiding this comment.
@optix2000 thanks, lgtm.
I defer the final review to @howardjohn.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: optix2000, snorwin, youngnick The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/retest |
…-sigs#4750) The behavior is explicitly specified, but some controllers do not conform.
|
@rikatz: new pull request created: #4778 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind test
/area conformance-test
What this PR does / why we need it:
Add tests for null/empty list
backendRefsThe behavior is explicitly specified, but some controllers do not conform.
Which issue(s) this PR fixes:
N/A
Does this PR introduce a user-facing change?: