Skip to content

conformance: Add tests for omitted and empty backendRefs - #4750

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
optix2000:main
Apr 17, 2026
Merged

k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
optix2000:main

Conversation

@optix2000

Copy link
Copy Markdown
Contributor

What type of PR is this?
/kind test
/area conformance-test

What this PR does / why we need it:
Add tests for null/empty list backendRefs
The behavior is explicitly specified, but some controllers do not conform.

Which issue(s) this PR fixes:
N/A

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/test area/conformance-test Issues or PRs related to Conformance tests. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 13, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Welcome @optix2000!

It looks like this is your first PR to kubernetes-sigs/gateway-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/gateway-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Hi @optix2000. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 13, 2026
@optix2000 optix2000 changed the title conformance: Add tests for ommitted and empty backendRefs conformance: Add tests for omitted and empty backendRefs Apr 13, 2026
@snorwin

snorwin commented Apr 14, 2026

Copy link
Copy Markdown
Member

@optix2000, did you also open an issue on the implementation's repository to let them know about this problem?

@snorwin

snorwin commented Apr 14, 2026

Copy link
Copy Markdown
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 14, 2026
@optix2000

Copy link
Copy Markdown
Contributor Author

@optix2000, did you also open an issue on the implementation's repository to let them know about this problem?

Lets just say that they don't agree it's a problem because the comformance tests pass.

@linux-foundation-easycla

linux-foundation-easycla Bot commented Apr 14, 2026 •

Copy link
Copy Markdown

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: optix2000 / name: Weilu Jia (17b169c)

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 14, 2026
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 14, 2026
@optix2000

Copy link
Copy Markdown
Contributor Author

/retest

@howardjohn

Copy link
Copy Markdown
Contributor

FWIW I had a bug this exact test would have caught (a while ago) and was surprised it wasn't covered. So 👍 from me

@youngnick

Copy link
Copy Markdown
Contributor

I agree, we mandate this behavior, we should test it.

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2026
@youngnick youngnick removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2026
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2026
The behavior is explicitly specified, but some controllers do not
conform.

@snorwin snorwin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@optix2000 thanks, lgtm.

I defer the final review to @howardjohn.

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: optix2000, snorwin, youngnick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rikatz

rikatz commented Apr 17, 2026

Copy link
Copy Markdown
Member

/lgtm
Thanks @optix2000

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 17, 2026
@optix2000

Copy link
Copy Markdown
Contributor Author

/retest

@k8s-ci-robot
k8s-ci-robot merged commit 42d61e2 into kubernetes-sigs:main Apr 17, 2026
20 checks passed
@optix2000

Copy link
Copy Markdown
Contributor Author

@snorwin @rikatz Should this test be backported given this spec has been around since forever?

ericdbishop pushed a commit to ericdbishop/gateway-api that referenced this pull request Apr 22, 2026
…-sigs#4750)

The behavior is explicitly specified, but some controllers do not
conform.
@rikatz

rikatz commented Apr 22, 2026

Copy link
Copy Markdown
Member

yes apparently this is a behavior that wasn't being verified but is common among implementations.

I will open the cherry-pick and defer to release managers (@kflynn @bexxmodd )

/cherry-pick release-1.5

@k8s-infra-cherrypick-robot

Copy link
Copy Markdown
Contributor

@rikatz: new pull request created: #4778

Details

In response to this:

yes apparently this is a behavior that wasn't being verified but is common among implementations.

I will open the cherry-pick and defer to release managers (@kflynn @bexxmodd )

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance-test Issues or PRs related to Conformance tests. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/test lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants