Skip to content

Update the bundle version for VAP and add it as a release step. - #4759

Merged
k8s-ci-robot merged 8 commits into
kubernetes-sigs:mainfrom
bexxmodd:vap/semver1
Apr 28, 2026
Merged

k8s-ci-robot merged 8 commits into
kubernetes-sigs:mainfrom
bexxmodd:vap/semver1

Conversation

@bexxmodd

Copy link
Copy Markdown
Contributor

What type of PR is this?
/kind bug
Which issue(s) this PR fixes:
Fixes #4739

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 15, 2026
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 15, 2026
@youngnick

Copy link
Copy Markdown
Contributor

/retest

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 16, 2026
@k8s-ci-robot
k8s-ci-robot requested a review from kflynn April 16, 2026 19:23

@mikemorris mikemorris left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

@mikemorris: GitHub didn't allow me to request PR reviews from the following users: jaiveerk.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @jaiveerk @kflynn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 16, 2026

@kflynn kflynn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only concern here is allowing v0 tags in the Standard-channel VAP, which is a bit of a strange concern in practice, but take a look. 🙂 Thanks for jumping on this! 🙂

Comment thread tests/vap/vap_test.go Resolved
Comment thread RELEASE.md Resolved
Comment thread RELEASE.md Resolved
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 20, 2026
@bexxmodd

Copy link
Copy Markdown
Contributor Author

/retest

@kflynn
kflynn self-requested a review April 23, 2026 15:54

@kflynn kflynn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'm good with this now, thanks @bexxmodd! 🙂

@kflynn

kflynn commented Apr 23, 2026

Copy link
Copy Markdown
Contributor

/lgtm
/approve

(not that I think those'll both work 😂)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 23, 2026
@rikatz

rikatz commented Apr 28, 2026

Copy link
Copy Markdown
Member

/approve

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bexxmodd, kflynn, rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2026
@k8s-ci-robot
k8s-ci-robot merged commit efb7442 into kubernetes-sigs:main Apr 28, 2026
20 checks passed
@bexxmodd
bexxmodd deleted the vap/semver1 branch April 29, 2026 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect Bundle Version Annotation on VAP/VAPB for Gateway 1.5.1

6 participants