Repository navigation
conformance: make timeout and other fields configurable via yaml - #4773
Conversation
Signed-off-by: Eric Bishop <ericbish.dev@gmail.com>
Signed-off-by: Eric Bishop <ericbish.dev@gmail.com>
|
Hi @ericdbishop. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cc |
Signed-off-by: Eric Bishop <ericbish.dev@gmail.com>
Signed-off-by: Eric Bishop <ericbish.dev@gmail.com>
Signed-off-by: Eric Bishop <ericbish.dev@gmail.com>
Signed-off-by: Eric Bishop <ericbish.dev@gmail.com>
fd6ed57 to
f381a14
Compare
Signed-off-by: Eric Bishop <ericbish.dev@gmail.com>
| return err | ||
| } | ||
|
|
||
| v := reflect.ValueOf(tc).Elem() |
There was a problem hiding this comment.
let's just confirm this is the best approach.
There was a problem hiding this comment.
I feel like this is the best approach to avoid changing the type of the duration fields or wrapping Duration. I had tried changing the type to metav1.Duration and it resulted in a lot of code changes: f9ba683#diff-072d1356145c7619d3b242a24c0b5178dd155e84cca0880894a10cc4f2a50302
Also, it might help to check out this other comment thread: #4773 (comment).
All that being said, I will make a change to avoid the panic if a non-duration json tag is added to the timeout struct.
| ClientOptions client.Options | ||
| Clientset clientset.Interface | ||
| RestConfig *rest.Config | ||
| AddressType string |
There was a problem hiding this comment.
based on our sync review, we are not sure this is being used, so please take a look what happens if we just drop this field
There was a problem hiding this comment.
I think it should be removed since it has no affect on the testing. Making that change.
|
As we also have discussed, here are AI findings :) https://gist.github.com/rikatz/a10ecf57342aac61e5dff50039f1721d |
Signed-off-by: Eric Bishop <ericbish.dev@gmail.com>
Signed-off-by: Eric Bishop <ericbish.dev@gmail.com>
Signed-off-by: Eric Bishop <ericbish.dev@gmail.com>
Signed-off-by: Eric Bishop <ericbish.dev@gmail.com>
Signed-off-by: Eric Bishop <ericbish.dev@gmail.com>
Signed-off-by: Eric Bishop <ericbish.dev@gmail.com>
Signed-off-by: Eric Bishop <ericbish.dev@gmail.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ericdbishop, rikatz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/area conformance-machinery
What this PR does / why we need it:
See #4346. Makes timeouts and other conformance option fields configurable via a yaml file, whose path is passed in as a flag. This is ultimately a step towards making conformance a separate binary to distribute to implementations.
When a conformance option is configured via both yaml and a flag, the flag takes precedence. Flag values only override yaml configuration if the flag was explicitly passed in via the command line.
WIP: Deciding additional fields of the configuration structure that should be accepted in the yaml configuration.
AI disclosure: Used copilot to review my code and make some idiomatic code optimizations.
Which issue(s) this PR fixes:
Fixes #4346
Does this PR introduce a user-facing change?: