Repository navigation
Make conformance reports require just major and minor GW API versions - #4792
Conversation
|
/retest |
|
/test pull-gateway-api-verify |
489bdef to
b70a1e2
Compare
b70a1e2 to
134a365
Compare
snorwin
left a comment
There was a problem hiding this comment.
@rikatz what about v1.4.1, v1.2.1, and v1.1.1, would it be worth consolidating those as well?
I also think the reports for versions < 1.0 could probably be removed from the repository, but that's probably worth its own discussion.
|
@snorwin it works for both cases. I intentionally left it working for both cases with or without patch version. v1.4 and lower have some conflicting reports and I didn't wanted to mess with it |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: howardjohn, rikatz, snorwin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel I am assuming @howardjohn approval is also a lgtm and this got some soak time. Thanks folks! |
|
/test pull-gateway-api-verify |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Make conformance stick with major.minor and ignore patch versions for reports, for the wizard matching and etc
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: