Skip to content

Make conformance reports require just major and minor GW API versions - #4792

Merged
k8s-ci-robot merged 2 commits into
kubernetes-sigs:mainfrom
rikatz:conformance-major-minor
Apr 30, 2026
Merged

k8s-ci-robot merged 2 commits into
kubernetes-sigs:mainfrom
rikatz:conformance-major-minor

Conversation

@rikatz

@rikatz rikatz commented Apr 24, 2026

Copy link
Copy Markdown
Member

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

Make conformance stick with major.minor and ignore patch versions for reports, for the wizard matching and etc

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 24, 2026
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 24, 2026
@rikatz

rikatz commented Apr 24, 2026

Copy link
Copy Markdown
Member Author

/cc @howardjohn @mikemorris @snorwin

@rikatz

rikatz commented Apr 24, 2026

Copy link
Copy Markdown
Member Author

/retest
ci is stuck

@rikatz

rikatz commented Apr 24, 2026

Copy link
Copy Markdown
Member Author

/test pull-gateway-api-verify

@rikatz rikatz changed the title WIP: Move conformance reports excluding patch version Make conformance reports require just major and minor versions Apr 24, 2026
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 24, 2026
@rikatz rikatz changed the title Make conformance reports require just major and minor versions Make conformance reports require just major and minor GW API versions Apr 24, 2026
@rikatz
rikatz force-pushed the conformance-major-minor branch from 489bdef to b70a1e2 Compare April 24, 2026 22:00
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 24, 2026
@rikatz
rikatz force-pushed the conformance-major-minor branch from b70a1e2 to 134a365 Compare April 24, 2026 22:24
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 24, 2026

@snorwin snorwin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rikatz what about v1.4.1, v1.2.1, and v1.1.1, would it be worth consolidating those as well?

I also think the reports for versions < 1.0 could probably be removed from the repository, but that's probably worth its own discussion.

@rikatz

rikatz commented Apr 27, 2026

Copy link
Copy Markdown
Member Author

@snorwin it works for both cases. I intentionally left it working for both cases with or without patch version. v1.4 and lower have some conflicting reports and I didn't wanted to mess with it

@snorwin snorwin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rikatz in that case, this works for me.

/lgtm
/hold for others to review

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 27, 2026
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 27, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: howardjohn, rikatz, snorwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rikatz

rikatz commented Apr 30, 2026

Copy link
Copy Markdown
Member Author

/hold cancel

I am assuming @howardjohn approval is also a lgtm and this got some soak time.

Thanks folks!

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 30, 2026
@rikatz

rikatz commented Apr 30, 2026

Copy link
Copy Markdown
Member Author

/test pull-gateway-api-verify

@k8s-ci-robot
k8s-ci-robot merged commit 50c33a0 into kubernetes-sigs:main Apr 30, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants