Skip to content

fix: drop GRPCRoute from supported kinds assertion as the test does not require to support them - #4805

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
snorwin:fix-listenerset-test
Apr 30, 2026
Merged

k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
snorwin:fix-listenerset-test

Conversation

@snorwin

@snorwin snorwin commented Apr 28, 2026

Copy link
Copy Markdown
Member

What type of PR is this?

/kind bug
/area conformance-test

What this PR does / why we need it:
Implementations that do not support GRPCRoute currently cannot pass the ListenerSetAllowedRoutesNamespaces and ListenerSetHTTPRouting tests, because both assert that GRPCRoute is present in SupportedKinds.

There are two ways to address this, either add GRPCRoute as a prerequisite feature for these tests, or relax the assertion so it does not require GRPCRoute to be present in SupportedKinds.
Since neither test actually uses GRPCRoute functionality, this PR takes the second approach and removes GRPCRoute from the SupportedKinds assertion.

This is a blocker and should be backported to 1.5.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

…ot require to support them

Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. area/conformance-test Issues or PRs related to Conformance tests. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 28, 2026
@snorwin

snorwin commented Apr 28, 2026

Copy link
Copy Markdown
Member Author

/cc @davidjumani @rikatz

@rikatz

rikatz commented Apr 30, 2026

Copy link
Copy Markdown
Member

/lgtm
/approve
thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 30, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rikatz, snorwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2026
@k8s-ci-robot
k8s-ci-robot merged commit dcbd0ea into kubernetes-sigs:main Apr 30, 2026
19 of 20 checks passed
@snorwin

snorwin commented May 1, 2026

Copy link
Copy Markdown
Member Author

/cherry-pick release-1.5

@k8s-infra-cherrypick-robot

Copy link
Copy Markdown
Contributor

@snorwin: new pull request created: #4813

Details

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance-test Issues or PRs related to Conformance tests. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants