Skip to content

test(conformance): add tests for Gateway listener Accepted condition with UnsupportedProtocol reason - #4807

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
snorwin:test-unsupported-protocol
May 4, 2026
Merged

k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
snorwin:test-unsupported-protocol

Conversation

@snorwin

@snorwin snorwin commented Apr 29, 2026 •

Copy link
Copy Markdown
Member

What type of PR is this?

/kind test
/area conformance-test

What this PR does / why we need it:
The ListenersNotValid reason for the Gateway Accepted condition and the UnsupportedProtocol reason for the Listener Accepted condition were so far not covered by the conformance tests. This PR adds a test to cover both.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Added a conformance test covering the Gateway `Accepted` condition with reason `ListenersNotValid` and the Listener `Accepted` condition with reason `UnsupportedProtocol`

…with UnsupportedProtocol reason

Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/test area/conformance-test Issues or PRs related to Conformance tests. labels Apr 29, 2026
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 29, 2026
@snorwin

snorwin commented Apr 29, 2026

Copy link
Copy Markdown
Member Author

Findings from running the proposed test against implementations:

  • Airlock Microgateway: conditions are set correctly, but supportedKinds is set incorrectly on the unsupported listener
  • Cilium and NGINX Gateway Fabric: fail to reconcile the Gateway with a "failed to update status" error, looks like an issue updating supportedKinds
  • kgateway: conditions are correct, but the Gateway's Accepted condition does not get reason ListenersNotValid in the mixed supported/unsupported case (arguably this assertion may be too strict)
  • Envoy Gateway and Istio: mark the Gateway as accepted even when there are no valid listeners

/cc @davidjumani @zirain

@youngnick

Copy link
Copy Markdown
Contributor

This makes sense, LGTM.

I'll approve and leave this for someone else to give the final LGTM.

/approve

@rikatz

rikatz commented May 4, 2026

Copy link
Copy Markdown
Member

/lgtm
/approve
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 4, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rikatz, snorwin, youngnick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
k8s-ci-robot merged commit 2e910ab into kubernetes-sigs:main May 4, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance-test Issues or PRs related to Conformance tests. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/test lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants