Repository navigation
test(conformance): add normative tests for HTTPRoute retries - #4817
Conversation
|
/cc @mikemorris |
118e621 to
19739c0
Compare
|
/retest |
19739c0 to
fcf74d0
Compare
fcf74d0 to
5fd2269
Compare
| codes: | ||
| - 500 | ||
| attempts: 3 | ||
| backoff: 100ms |
There was a problem hiding this comment.
we are not really testing the backoff, right? Should we be adding it here, or open a followup for implementations that decide to support it, even because the API specified different possible behaviors for the backoff?
There was a problem hiding this comment.
yes, we are not really testing the backoff here, I decided to skip it for now and just set the interval low so the test is fast. According to the spec, the backoff would only apply from the first retry attempt, and implementations may use an exponential or alternative backoff strategy for subsequent attempts, so the behavior isn't guaranteed across implementations.
My experience is that asserting timing often introduces flakiness in tests. I'm happy to open a followup PR to test e.g. backoff of 1s and 2s.
There was a problem hiding this comment.
I swear we had some mechanism in the HTTPRouteTimeout tests to mock timing - maybe @kflynn remembers?
There was a problem hiding this comment.
Open to making the behavior more explicit if we wanted to add something like a strategy: { exponential, linear } field with most implementations only supporting one (and probably exponential as default to avoid verbosity and since it's almost always preferable).
5fd2269 to
cb1f2f0
Compare
cb1f2f0 to
2694ac3
Compare
2694ac3 to
b068554
Compare
Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>
b068554 to
580c531
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rikatz, snorwin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm tested on Istio, Envoy Gateway and kgateway, works as expected. Also I don't have further comments to be addressed here. Thanks @snorwin |
|
/hold cancel |
|
/retest-required |
|
/test pull-gateway-api-verify |
What type of PR is this?
/kind test
/area conformance-test
What this PR does / why we need it:
This PR adds a new conformance test,
HTTPRouteRetries, which validates that implementations correctly handle theretryconfiguration on HTTPRoute rules.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: