Repository navigation
Enable golangci-lint modernize linter - #4821
Merged
Merged
Conversation
erikgb
force-pushed
the
modernize-linter
branch
2 times, most recently
from
May 2, 2026 15:34
38e9b8d to
f157854
Compare
Signed-off-by: Erik Godding Boye <egboye@gmail.com>
Member
|
This is great, thanks @erikgb /lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: erikgb, rikatz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
As Go evolves, we should try to keep up with new features. In recent versions of golangci-lint, there is a new linter that can help us with this: modernize! We have enabled it across all our projects, and I propose enabling it here as well. Most of the changes were auto-fixed by golangci-lint by running
golangci-lint run --fixacross the Go modules. Which means they should be rather safe.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: