Repository navigation
[gep-1713] ListenerSet: Fix typos and other inconsistencies - #4824
Merged
Merged
Conversation
Contributor
Author
|
/assign @youngnick |
rikatz
reviewed
May 4, 2026
Comment on lines
+918
to
+920
| - `NotAllowed` — the `parentRef` does not allow attachment | ||
| - `ParentNotAccepted` — the `parentRef` is not accepted (e.g. invalid address) | ||
| - `ListenersNotValid` — one or more listeners in the set are invalid (or using an unsupported feature) |
Member
There was a problem hiding this comment.
Suggested change
| - `NotAllowed` — the `parentRef` does not allow attachment | |
| - `ParentNotAccepted` — the `parentRef` is not accepted (e.g. invalid address) | |
| - `ListenersNotValid` — one or more listeners in the set are invalid (or using an unsupported feature) | |
| - `NotAllowed` - the `parentRef` does not allow attachment | |
| - `ParentNotAccepted` - the `parentRef` is not accepted (e.g. invalid address) | |
| - `ListenersNotValid` - one or more listeners in the set are invalid (or using an unsupported feature) |
it kinda rendered with that weird 2 dashes here
Contributor
Author
Contributor
Author
There was a problem hiding this comment.
I think the em-dash is ok here
rikatz
reviewed
May 4, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, rikatz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
/hold cancel |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Looking at the GEP when it's rendered on the website a bunch of examples weren't being highlighted.
I put the entire markdown through claude and asked it to fix that formatting and any grammatical errors.