Skip to content

[gep-1713] ListenerSet: Fix typos and other inconsistencies - #4824

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
dprotaso:fix-typos-formatting
May 8, 2026
Merged

k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
dprotaso:fix-typos-formatting

Conversation

@dprotaso

@dprotaso dprotaso commented May 3, 2026 •

Copy link
Copy Markdown
Contributor

Looking at the GEP when it's rendered on the website a bunch of examples weren't being highlighted.

I put the entire markdown through claude and asked it to fix that formatting and any grammatical errors.

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 3, 2026
@k8s-ci-robot
k8s-ci-robot requested review from howardjohn and snorwin May 3, 2026 17:31
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/gep PRs related to Gateway Enhancement Proposal(GEP) size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 3, 2026
@dprotaso dprotaso changed the title fix typos and other inconsistencies [gep-1713] ListenerSet: Fix typos and other inconsistencies May 3, 2026
@dprotaso

dprotaso commented May 3, 2026

Copy link
Copy Markdown
Contributor Author

/assign @youngnick

Comment thread geps/gep-1713/index.md
Comment on lines +918 to +920
- `NotAllowed` — the `parentRef` does not allow attachment
- `ParentNotAccepted` — the `parentRef` is not accepted (e.g. invalid address)
- `ListenersNotValid` — one or more listeners in the set are invalid (or using an unsupported feature)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `NotAllowed` — the `parentRef` does not allow attachment
- `ParentNotAccepted` — the `parentRef` is not accepted (e.g. invalid address)
- `ListenersNotValid` — one or more listeners in the set are invalid (or using an unsupported feature)
- `NotAllowed` - the `parentRef` does not allow attachment
- `ParentNotAccepted` - the `parentRef` is not accepted (e.g. invalid address)
- `ListenersNotValid` - one or more listeners in the set are invalid (or using an unsupported feature)

it kinda rendered with that weird 2 dashes here

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused - what's the issue? I'm seeing the following on the rendered deploy of this PR

Screenshot 2026-05-04 at 10 06 02 AM

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the em-dash is ok here

Comment thread geps/gep-1713/index.md Resolved

@rikatz rikatz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
thanks kDave

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 8, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2026
@dprotaso

dprotaso commented May 8, 2026

Copy link
Copy Markdown
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 8, 2026
@k8s-ci-robot
k8s-ci-robot merged commit 1cb3bab into kubernetes-sigs:main May 8, 2026
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/gep PRs related to Gateway Enhancement Proposal(GEP) lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants