Repository navigation
docs: ensure example files reference proper pages + update API version - #4840
Conversation
Signed-off-by: Joey Chen <142381267+JoeyC-Dev@users.noreply.github.com>
|
Hi @JoeyC-Dev. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@JoeyC-Dev we are going to move to docsy/hugo sooner this week, I would like to wait that PR to merge and then we fix this one, sounds good? Thanks for the work here, I appreciate the help and improvements! |
|
@rikatz Good to know. I’ll check back on this PR next week and see what I can do then. |
|
hugo/docsy is merged, go ahead. You will probably need to rebase and re-verify things |
- Use content-relative doc paths instead of legacy `site-src/` paths or full `site/content/en` paths. Signed-off-by: Joey Chen <142381267+JoeyC-Dev@users.noreply.github.com>
Signed-off-by: Joey Chen <142381267+JoeyC-Dev@users.noreply.github.com>
|
@rikatz I’ve updated the example files with the latest references. Full report below: Reference List DetailsFiles Needing Attention Files With No References Note that the I also updated some GEP files that still referenced the old I checked one of the YAML file ( I also checked Anyway, the YAML files have no references are for another PR to resolve. I'm also concerned that adding a GitHub workflow to validate these YAML files will likely fail if the theme changes in the future (like recent Docsy change). So not sure if going to make such workflow. |
|
/ok-to-test |
|
/lgtm |
|
/hold cancel |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoeyC-Dev, rikatz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
v1beta1tov1.Note: technically, if this commit does not add any reference lines to the existing example YAML files, then those example YAML files are not referenced by any files. I already added/fixed all example YAML files that are quoted by a file.
Files With No References:
Which issue(s) this PR fixes:
N/A
Does this PR introduce a user-facing change?: