Repository navigation
[breaking change] Remove optional marker from ReferenceGrant.Spec - #4845
Conversation
|
Looks sane from here, thanks @bexxmodd! /approve |
|
@kflynn: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bexxmodd, kflynn, rikatz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@kflynn: new pull request created: #4847 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR marks referencegrant.spec as required. A ReferenceGrant without a .spec doesn't have a meaning, and can break a controller expecting it to be available
Does this PR introduce a user-facing change?: