Skip to content

[breaking change] Remove optional marker from ReferenceGrant.Spec - #4845

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
bexxmodd:vuln/rg
May 13, 2026
Merged

k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
bexxmodd:vuln/rg

Conversation

@bexxmodd

@bexxmodd bexxmodd commented May 13, 2026 •

Copy link
Copy Markdown
Contributor

What type of PR is this?
/kind bug

What this PR does / why we need it:

This PR marks referencegrant.spec as required. A ReferenceGrant without a .spec doesn't have a meaning, and can break a controller expecting it to be available

Does this PR introduce a user-facing change?:

Make referencegrant.spec field as required

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels May 13, 2026
@k8s-ci-robot
k8s-ci-robot requested review from rikatz and thockin May 13, 2026 19:13
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 13, 2026
@bexxmodd bexxmodd changed the title Remove optional marker [breaking change] Remove optional marker from ReferenceGrant.Spec May 13, 2026
@rikatz

rikatz commented May 13, 2026

Copy link
Copy Markdown
Member

/approve
/lgtm
/hold
@kflynn for your second pass

thanks @bexxmodd

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 13, 2026
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 13, 2026
@kflynn

kflynn commented May 13, 2026

Copy link
Copy Markdown
Contributor

Looks sane from here, thanks @bexxmodd!

/approve
/unhold
/cherry-pick release-1.5

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 13, 2026
@k8s-infra-cherrypick-robot

Copy link
Copy Markdown
Contributor

@kflynn: once the present PR merges, I will cherry-pick it on top of release-1.5 in a new PR and assign it to you.

Details

In response to this:

Looks sane from here, thanks @bexxmodd!

/approve
/unhold
/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bexxmodd, kflynn, rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
k8s-ci-robot merged commit fc998d1 into kubernetes-sigs:main May 13, 2026
56 checks passed
@k8s-infra-cherrypick-robot

Copy link
Copy Markdown
Contributor

@kflynn: new pull request created: #4847

Details

In response to this:

Looks sane from here, thanks @bexxmodd!

/approve
/unhold
/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants