Skip to content

fix: initialize retry count map to prevent nil map panic - #4866

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
snorwin:fix-echo-basic-retry-simulation
May 15, 2026
Merged

k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
snorwin:fix-echo-basic-retry-simulation

Conversation

@snorwin

@snorwin snorwin commented May 15, 2026

Copy link
Copy Markdown
Member

What type of PR is this?

/kind bug
/area conformance-machinery

What this PR does / why we need it:

2026/05/15 13:18:37 http: panic serving 192.168.206.82:48384: assignment to entry in nil map
goroutine 532 [running]:
net/http.(*conn).serve.func1()
    net/http/server.go:1943 +0xd3
panic({0x9f7be0?, 0xfdcf50?})
    runtime/panic.go:783 +0x132
main.(*retrySimulation).retrySimulationHandler(0xc000023590, {0xba17d8, 0xc00033c000}, 0xc000120140)
    sigs.k8s.io/gateway-api/conformance/echo-basic/echo-basic.go:209 +0x247
net/http.HandlerFunc.ServeHTTP(0xc0000cf980?, {0xba17d8?, 0xc00033c000?}, 0x479105?)
    net/http/server.go:2322 +0x29
net/http.(*ServeMux).ServeHTTP(0xc000324004?, {0xba17d8, 0xc00033c000}, 0xc000120140)
    net/http/server.go:2861 +0x1c7
main.(*preserveSlashes).ServeHTTP(0xc000023610, {0xba17d8, 0xc00033c000}, 0xc000120140)
    sigs.k8s.io/gateway-api/conformance/echo-basic/echo-basic.go:71 +0x9d
net/http.serverHandler.ServeHTTP({0xc0003481c0?}, {0xba17d8?, 0xc00033c000?}, 0x6?)
    net/http/server.go:3340 +0x8e
net/http.(*conn).serve(0xc00021c5a0, {0xba2550, 0xc00020a120})
    net/http/server.go:2109 +0x665
created by net/http.(*Server).Serve in goroutine 7
    net/http/server.go:3493 +0x485

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. area/conformance-machinery Issues or PRs related to the machinery and the suite used to run conformance tests. labels May 15, 2026
@k8s-ci-robot
k8s-ci-robot requested a review from kl52752 May 15, 2026 13:24
@snorwin

snorwin commented May 15, 2026

Copy link
Copy Markdown
Member Author

/cc @rikatz

@k8s-ci-robot
k8s-ci-robot requested a review from mikemorris May 15, 2026 13:24
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 15, 2026
@k8s-ci-robot
k8s-ci-robot requested a review from rikatz May 15, 2026 13:24
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 15, 2026
@rikatz

rikatz commented May 15, 2026

Copy link
Copy Markdown
Member

/lgtm
/approve

ooops, missed this one as well
thanks

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 15, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rikatz, snorwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2026
@k8s-ci-robot
k8s-ci-robot merged commit d9e148d into kubernetes-sigs:main May 15, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance-machinery Issues or PRs related to the machinery and the suite used to run conformance tests. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants