Skip to content

Update TCPRoute gep to add more conformance and clarification - #4878

Merged
k8s-ci-robot merged 2 commits into
kubernetes-sigs:mainfrom
rikatz:tcproute-improvements
May 18, 2026
Merged

k8s-ci-robot merged 2 commits into
kubernetes-sigs:mainfrom
rikatz:tcproute-improvements

Conversation

@rikatz

@rikatz rikatz commented May 18, 2026

Copy link
Copy Markdown
Member

What type of PR is this?
/kind gep

What this PR does / why we need it:
Update TCPRoute GEP:

  • Move to experimental
  • Address Provisional TODOs
  • Add expected workflow
  • Add missing conformance tests

Which issue(s) this PR fixes:
Part of #2644

Does this PR introduce a user-facing change?:

Move TCPRoute GEP to Experimental

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/gep PRs related to Gateway Enhancement Proposal(GEP) labels May 18, 2026
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 18, 2026
Comment thread geps/gep-2644/index.md Resolved
Comment thread geps/gep-2644/index.md Resolved
@zac-nixon

Copy link
Copy Markdown
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 18, 2026
@kflynn

kflynn commented May 18, 2026

Copy link
Copy Markdown
Contributor

I think this is also OK for Experimental, thanks @rikatz! FTR, this is a grandfathered resource, which is why we're skipping Implementable.

/lgtm
/approve
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 18, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kflynn, rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Comment thread geps/gep-2644/index.md
2. If timestamps are equal, the Route appearing first in alphabetical order
(`namespace/name`).

All attached TCPRoutes are `Accepted`, consistent with how other route types

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This contradicts the current documentation for Accepted routes;

	// A Route MUST be considered "Accepted" if at least one of the Route's
	// rules is implemented by the Gateway.

Is there a specific concern about having this as accepted = false?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a long standing discussion :( tbh I think this is what we do today on every route, but I vaguely remember some discussion about it (@rostislavbobo or @kl52752 may have better memory than me)

@k8s-ci-robot
k8s-ci-robot merged commit 3e4ef89 into kubernetes-sigs:main May 18, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/gep PRs related to Gateway Enhancement Proposal(GEP) lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants