Repository navigation
Update TCPRoute gep to add more conformance and clarification - #4878
Conversation
|
/lgtm |
|
I think this is also OK for Experimental, thanks @rikatz! FTR, this is a grandfathered resource, which is why we're skipping Implementable. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kflynn, rikatz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| 2. If timestamps are equal, the Route appearing first in alphabetical order | ||
| (`namespace/name`). | ||
|
|
||
| All attached TCPRoutes are `Accepted`, consistent with how other route types |
There was a problem hiding this comment.
This contradicts the current documentation for Accepted routes;
// A Route MUST be considered "Accepted" if at least one of the Route's
// rules is implemented by the Gateway.
Is there a specific concern about having this as accepted = false?
There was a problem hiding this comment.
This is a long standing discussion :( tbh I think this is what we do today on every route, but I vaguely remember some discussion about it (@rostislavbobo or @kl52752 may have better memory than me)
What type of PR is this?
/kind gep
What this PR does / why we need it:
Update TCPRoute GEP:
Which issue(s) this PR fixes:
Part of #2644
Does this PR introduce a user-facing change?: