Repository navigation
[release-1.6] conformance: add ListenerSet tests for Route parentRefs - #4912
Merged
k8s-ci-robot merged 3 commits intoMay 29, 2026
Conversation
Add a conformance test which validates that when a Route has both a parentRef to a Gateway and a parentRef to a ListenerSet, that the Accepted condition is evaluated independently for each of these parentRefs. This tests for a possible bug in the Gateway reconciler implementation that would set Accepted=True on all parentRefs for a route if any of them were accepted. Signed-off-by: Andrew Sauber <andrew.sauber@isovalent.com>
Add a conformance tests which validates that when a Route attaches to a ListenerSet sectionName, that the sectionName cannot be found if the Route only has a Gateway parentRef, even if a ListenerSet with that same Gateway parentRef would satisfy the sectionName. This tests for a possible bug in the Gateway reconciler that would aggregate sectionName checks regardless of parentRefs. Signed-off-by: Andrew Sauber <andrew.sauber@isovalent.com>
Add a conformance test which confirms that when a Route has a parentRef pointing to a ListenerSet, that the Route's status reflects exactly one parent, the ListenerSet, and not also that ListenerSet's Gateway. This tests for a possible bug in the Gateway reconciler that would associate the entire ancestry of a Route with that Route's status. Signed-off-by: Andrew Sauber <andrew.sauber@isovalent.com>
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: k8s-infra-cherrypick-robot, rikatz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #4899
/assign snorwin