Skip to content

[release-1.6] conformance: add ListenerSet tests for Route parentRefs - #4912

Merged
k8s-ci-robot merged 3 commits into
kubernetes-sigs:release-1.6from
k8s-infra-cherrypick-robot:cherry-pick-4899-to-release-1.6
May 29, 2026
Merged

k8s-ci-robot merged 3 commits into
kubernetes-sigs:release-1.6from
k8s-infra-cherrypick-robot:cherry-pick-4899-to-release-1.6

Conversation

@k8s-infra-cherrypick-robot

Copy link
Copy Markdown
Contributor

This is an automated cherry-pick of #4899

/assign snorwin

conformance: add ListenerSet tests for Route parentRef cases

asauber added 3 commits May 27, 2026 21:29
Add a conformance test which validates that when a Route has both a
parentRef to a Gateway and a parentRef to a ListenerSet, that the
Accepted condition is evaluated independently for each of these
parentRefs.

This tests for a possible bug in the Gateway reconciler implementation
that would set Accepted=True on all parentRefs for a route if any of
them were accepted.

Signed-off-by: Andrew Sauber <andrew.sauber@isovalent.com>
Add a conformance tests which validates that when a Route attaches to a
ListenerSet sectionName, that the sectionName cannot be found if the
Route only has a Gateway parentRef, even if a ListenerSet with that same
Gateway parentRef would satisfy the sectionName.

This tests for a possible bug in the Gateway reconciler that would
aggregate sectionName checks regardless of parentRefs.

Signed-off-by: Andrew Sauber <andrew.sauber@isovalent.com>
Add a conformance test which confirms that when a Route has a parentRef
pointing to a ListenerSet, that the Route's status reflects exactly one
parent, the ListenerSet, and not also that ListenerSet's Gateway.

This tests for a possible bug in the Gateway reconciler that would
associate the entire ancestry of a Route with that Route's status.

Signed-off-by: Andrew Sauber <andrew.sauber@isovalent.com>
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 27, 2026
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 27, 2026
@rikatz

rikatz commented May 28, 2026

Copy link
Copy Markdown
Member

/approve

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k8s-infra-cherrypick-robot, rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2026
@kflynn

kflynn commented May 29, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 29, 2026
@k8s-ci-robot
k8s-ci-robot merged commit e82b894 into kubernetes-sigs:release-1.6 May 29, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants