Skip to content

[release-1.6] fix: remove HTTPRoute retry tests with connection errors and backend timeouts - #4994

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:release-1.6from
snorwin:remove-retry-tests
Jun 19, 2026
Merged

k8s-ci-robot merged 1 commit into
kubernetes-sigs:release-1.6from
snorwin:remove-retry-tests

Conversation

@snorwin

@snorwin snorwin commented Jun 19, 2026

Copy link
Copy Markdown
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:
As we revisit how retries should behave on connection errors and clarify exactly what qualifies as a connection error, I want to remove these tests from the v1.6 release. We don't want implementations to be required to conform to assertions that are likely to change.

Which issue(s) this PR fixes:

Fixes #4977

Does this PR introduce a user-facing change?:

NONE

…timeouts

Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jun 19, 2026
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 19, 2026
@snorwin

snorwin commented Jun 19, 2026

Copy link
Copy Markdown
Member Author

/cc @rikatz @zirain

@k8s-ci-robot
k8s-ci-robot requested review from rikatz and zirain June 19, 2026 09:28
@zirain

zirain commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 19, 2026
@rikatz

rikatz commented Jun 19, 2026

Copy link
Copy Markdown
Member

/approve

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rikatz, snorwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2026
@k8s-ci-robot
k8s-ci-robot merged commit 2efc4a0 into kubernetes-sigs:release-1.6 Jun 19, 2026
16 checks passed
@zirain

zirain commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

@snorwin thanks for taking this forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants