Skip to content

Fix/xbackend status parent name - #5187

Merged
kubernetes-prow[bot] merged 1 commit into
kubernetes-sigs:mainfrom
Stevenjin8:fix/xbackend-status-parent-name
Aug 26, 2026
Merged

kubernetes-prow[bot] merged 1 commit into
kubernetes-sigs:mainfrom
Stevenjin8:fix/xbackend-status-parent-name

Conversation

@Stevenjin8

Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind bug
/kind cleanup
/kind documentation

What this PR does / why we need it:

Right now, the docs are a bit confusing:

image

Somewhat worse, the name of the field when serialized to JSON does not match with the go type

	// AncestorRef identifies the parent resource that this status is associated with.
	//
	// +required
	AncestorRef v1.ParentReference `json:"parentRef"`

I dont have strong feelings as to whether we stick with parentRef or ancestorRef. I chose parentRef so implementations, rather than end users, have to deal with the breaking change.

Regardless I think we should have it be consistent and rip the bandaid off while this is still experimental.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Switch the name of `BackendAncestorStatus.AncestorRef` to `BackendAncestorStatus.ParentRef` in Go generated types for consistency with docs and JSON/YAML serialization.

cc @keithmattix @ericdbishop

@kubernetes-prow kubernetes-prow Bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 19, 2026
@kubernetes-prow
kubernetes-prow Bot requested review from gcs278 and youngnick August 19, 2026 13:55
@kubernetes-prow kubernetes-prow Bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/gep PRs related to Gateway Enhancement Proposal(GEP) labels Aug 19, 2026

@keithmattix keithmattix left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is my bad; I changed the type but forgot the tag. +1 to making the change now

Comment thread apisx/v1alpha1/xbackend_types.go Resolved
@Stevenjin8
Stevenjin8 force-pushed the fix/xbackend-status-parent-name branch from f983a87 to 6926202 Compare August 26, 2026 15:30
@kubernetes-prow kubernetes-prow Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 26, 2026

@keithmattix keithmattix left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@Stevenjin8
Stevenjin8 requested a review from keithmattix August 26, 2026 15:49
@snorwin

snorwin commented Aug 26, 2026

Copy link
Copy Markdown
Member

/retest

@snorwin snorwin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Stevenjin8 thanks.
/lgtm

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 26, 2026
@robscott

Copy link
Copy Markdown
Member

Thanks @Stevenjin8!

/approve

@kubernetes-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: keithmattix, robscott, snorwin, Stevenjin8

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2026
@robscott

Copy link
Copy Markdown
Member

/hold cancel

@kubernetes-prow kubernetes-prow Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 26, 2026
@kubernetes-prow
kubernetes-prow Bot merged commit 11a07fb into kubernetes-sigs:main Aug 26, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. kind/gep PRs related to Gateway Enhancement Proposal(GEP) lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants