Repository navigation
Fix/xbackend status parent name - #5187
Merged
kubernetes-prow[bot] merged 1 commit intoAug 26, 2026
Merged
kubernetes-prow[bot] merged 1 commit into
kubernetes-prow[bot] merged 1 commit into
Conversation
keithmattix
reviewed
Aug 19, 2026
keithmattix
left a comment
Contributor
There was a problem hiding this comment.
This is my bad; I changed the type but forgot the tag. +1 to making the change now
Stevenjin8
force-pushed
the
fix/xbackend-status-parent-name
branch
from
August 26, 2026 15:30
f983a87 to
6926202
Compare
Member
|
/retest |
Member
|
Thanks @Stevenjin8! /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: keithmattix, robscott, snorwin, Stevenjin8 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/hold cancel |
kubernetes-prow
Bot
merged commit Aug 26, 2026
11a07fb
into
kubernetes-sigs:main
8 of 9 checks passed
14 of 33 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind cleanup
/kind documentation
What this PR does / why we need it:
Right now, the docs are a bit confusing:
Somewhat worse, the name of the field when serialized to JSON does not match with the go type
I dont have strong feelings as to whether we stick with
parentReforancestorRef. I choseparentRefso implementations, rather than end users, have to deal with the breaking change.Regardless I think we should have it be consistent and rip the bandaid off while this is still experimental.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:
cc @keithmattix @ericdbishop