Skip to content

api: align HTTPRouteRetry types to match the latest GEP revision - #5269

Merged
kubernetes-prow[bot] merged 2 commits into
kubernetes-sigs:mainfrom
snorwin:httproute-retries-api
Sep 22, 2026
Merged

kubernetes-prow[bot] merged 2 commits into
kubernetes-sigs:mainfrom
snorwin:httproute-retries-api

Conversation

@snorwin

@snorwin snorwin commented Sep 18, 2026

Copy link
Copy Markdown
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:
Follow-up for: #5167

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Clarified that implementations should only retry HTTPRoute requests on connection errors when it is safe to do so, and that `backoff` specifies the base interval for exponential backoff rather than the minimum interval.

Was AI used in preparing this PR?
/label ail/0

Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>
@kubernetes-prow kubernetes-prow Bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. ail/0 Categorizes a PR as having AI Influence Level 0 (human created, no AI) needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 18, 2026
@kubernetes-prow

Copy link
Copy Markdown

This issue is currently awaiting triage.

If Gateway API community members determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow kubernetes-prow Bot added needs-priority size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 18, 2026
@kubernetes-prow

Copy link
Copy Markdown

@snorwin: The label(s) /label triage/accepted , /label priority/high cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor, ci-short, ci-extended, ci-full, ail/0, ail/1, ail/2, ail/3, ail/4, ail/5. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

Details

In response to this:

/label triage/accepted
/label priority/high

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rikatz

rikatz commented Sep 21, 2026

Copy link
Copy Markdown
Member

/approve

/cc @youngnick @robscott for the lgtm, this aligns IMO with HTTPRouteRetry promotion and keeping the backoff as implementation specific right now is desired, given that each implementation has its own backoff definition

@kubernetes-prow kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2026
@rikatz

rikatz commented Sep 21, 2026

Copy link
Copy Markdown
Member

/approve cancel

@kubernetes-prow kubernetes-prow Bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2026

@robscott robscott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @snorwin!

Comment thread apis/v1/httproute_types.go Resolved
Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>
@kubernetes-prow kubernetes-prow Bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/gep PRs related to Gateway Enhancement Proposal(GEP) labels Sep 22, 2026
@snorwin
snorwin requested a review from robscott September 22, 2026 07:20
@rikatz

rikatz commented Sep 22, 2026

Copy link
Copy Markdown
Member

/lgtm
/approve
given this was the only comment from Rob as well, I think we can progress with it, thanks!
/hold cancel

@kubernetes-prow kubernetes-prow Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 22, 2026
@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 22, 2026
@rikatz

rikatz commented Sep 22, 2026

Copy link
Copy Markdown
Member

/hold

@kubernetes-prow kubernetes-prow Bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Sep 22, 2026
@rikatz

rikatz commented Sep 22, 2026

Copy link
Copy Markdown
Member

sorry, let me ask Rob or Nick just to give a second pass

@robscott

Copy link
Copy Markdown
Member

Thanks @snorwin!

/approve
/hold cancel

@kubernetes-prow kubernetes-prow Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 22, 2026
@kubernetes-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rikatz, robscott, snorwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow
kubernetes-prow Bot merged commit 407b832 into kubernetes-sigs:main Sep 22, 2026
20 checks passed
@mikemorris

mikemorris commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Moved detailed explanation over to #5167 (comment) in GEP update comments, tl;dr LGTM.

Clarifications on unsafe retries are good. Thanks for tightening this up @snorwin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ail/0 Categorizes a PR as having AI Influence Level 0 (human created, no AI) approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/gep PRs related to Gateway Enhancement Proposal(GEP) lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants