Repository navigation
api: align HTTPRouteRetry types to match the latest GEP revision - #5269
Conversation
Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>
|
This issue is currently awaiting triage. If Gateway API community members determine this is a relevant issue, they will accept it by applying the The DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@snorwin: The label(s) DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/approve /cc @youngnick @robscott for the lgtm, this aligns IMO with HTTPRouteRetry promotion and keeping the backoff as implementation specific right now is desired, given that each implementation has its own backoff definition |
|
/approve cancel |
Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>
|
/lgtm |
|
/hold |
|
sorry, let me ask Rob or Nick just to give a second pass |
|
Thanks @snorwin! /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rikatz, robscott, snorwin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Moved detailed explanation over to #5167 (comment) in GEP update comments, tl;dr LGTM. Clarifications on unsafe retries are good. Thanks for tightening this up @snorwin! |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Follow-up for: #5167
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:
Was AI used in preparing this PR?
/label ail/0