Repository navigation
GEP-5075: Move ClusterTrustBundle proposal Experimental - #5272
Conversation
|
This issue is currently awaiting triage. If Gateway API community members determine this is a relevant issue, they will accept it by applying the The DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hi @davidesalerno. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
e0a8ad9 to
3597f6b
Compare
|
/cc |
3597f6b to
04d6af5
Compare
robscott
left a comment
There was a problem hiding this comment.
Thanks @davidesalerno!
/cc @kl52752
|
/ok-to-test |
Signed-off-by: Davide Salerno <dsalerno@redhat.com>
into the cluster Signed-off-by: Davide Salerno <dsalerno@redhat.com>
dedicated ClusterTrustBundleObjectRef, ExactlyOneOf validation, move ClusterTrustBundleFeature to gateway.go, consolidate the two experimental feature flags into a single ClusterTrustBundle feature, updating tests, regenerating CRDs, deepcopy, applyconfigurations, and openapi/swagger Signed-off-by: Davide Salerno <dsalerno@redhat.com>
generator,[C regenerating CRDs, deepcopy, applyconfigurations, and openapi/swagger Signed-off-by: Davide Salerno <dsalerno@redhat.com>
d32cfbd to
bc46217
Compare
ClusterTrustBundleRef, document exactly-one trust source, regenerating CRDs and openapi/swagger Align FrontendTLSValidation.ClusterTrustBundleRef with the BackendTLSPolicy equivalent by using InvalidKind, and correct the GEP to describe the ExactlyOneOf trust source constraint instead of a union.
…d bundles Also fixes the BackendTLSPolicy trust source wording that contradicted the ExactlyOneOf validation. Conformance tests deferred to a follow-up. Signed-off-by: Davide Salerno <dsalerno@redhat.com>
75dafc6 to
daac014
Compare
…o the standard channel The `must specify either CACertificateRefs or WellKnownCACertificates` and `must not contain both CACertificateRefs and WellKnownCACertificates` rules were emitted into both channels, so the experimental CRD rejected a BackendTLSPolicy whose only trust source was clusterTrustBundleRef, making the new field unusable. Move both rules behind `<gateway:standard:validation:XValidation:...>` so the experimental channel is covered by the ExactlyOneOf rule alone, matching the channel-scoped rule pattern already used for parentRefs in shared_types.go. The standard CRDs are unchanged. ExactlyOneOf only tests field presence, whereas the standard rules also required `size(caCertificateRefs) > 0`, so add an experimental-only MinItems=1 to keep an explicitly empty list from counting as a trust source. Split the channel-divergent CEL cases into backendtlspolicy_standard_test.go and backendtlspolicy_experimental_test.go, since the two channels now report different error messages. Signed-off-by: Davide Salerno <dsalerno@redhat.com>
Replace the BackendTLSPolicyClusterTrustBundle and GatewayClusterTrustBundle feature names with the single ClusterTrustBundle feature, and include it in both GatewayExtendedFeatures and BackendTLSPolicyExtendedFeatures. What an implementation must demonstrate now follows from the other features it claims: ClusterTrustBundle + BackendTLSPolicy covers clusterTrustBundleRef in BackendTLSPolicyValidation, and ClusterTrustBundle + GatewayFrontendClientCertificateValidation covers it in Gateway frontend TLS validation. This mirrors how the BackendTLSPolicy feature is scoped. Update the GEP conformance section accordingly. Signed-off-by: Davide Salerno <dsalerno@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidesalerno, robscott, snorwin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/lgtm Thanks @davidesalerno I am merging this based on a discussion I had with other maintainers yesterday about just fixing the followups (as you did!) + some Slack discussion with Norwin about findings. |
| // | ||
| // <gateway:experimental> | ||
| // +optional | ||
| ClusterTrustBundleRef *ClusterTrustBundleObjectRef `json:"clusterTrustBundleRef,omitempty"` |
There was a problem hiding this comment.
I apologize for being late, and am fine if its "too late" - was on PTO for a while.
This seems wrong. caCertificateRefs is meant for exactly this purpose. it makes no sense to have a specific ref here and a generic ref to do the same thing.
There was a problem hiding this comment.
I assume the purpose is that one is "cluster scoped" and one is "local namespace". But that is a poor distinction - we already have this same concept already in other APIs in gateway and handle this fine.
We can have a single field with name+kind+no namespace. If its cluster scope, it means "use the cluster scope one" and if its namespaced it means "use the local namespace one"
This is how GatewayClass.spec.parametersRef works
There was a problem hiding this comment.
there is some confusion here indeed, namespaced vs non namespaced was one case.
The other one that I can think is that initially we were considering about having the selectors that ClusterTrustBundle brings as well, but at some point the idea was missed. I asked Davide to reach by on Slack and we can discuss about it
| // | ||
| // +optional | ||
| // +kubebuilder:default=ClusterTrustBundle | ||
| Kind *Kind `json:"kind,omitempty"` |
There was a problem hiding this comment.
the type is named ClusterTrustBundleObjectRef. It does not make sense to have
clusterTrustBundleRef:
kind: NotClusterTrustBundleThat is like an api
configMapRef:
kind: NotConfigMap
What type of PR is this?
/kind gep
What this PR does / why we need it:
The changes in this PR are containing the implementation details needed to move the ClusterTrustBundle proposal from Provisional to Experimental
Which issue(s) this PR fixes:
Fixes #5075
Does this PR introduce a user-facing change?:
Was AI used in preparing this PR?
/label ail/1
I created the enhancement by hand and used AI in order to improve the wording