Repository navigation
fix(tests): remove HTTPRouteBackendRequestRedirect feature and related tests - #5279
Conversation
Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>
|
This issue is currently awaiting triage. If Gateway API community members determine this is a relevant issue, they will accept it by applying the The DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
I agree that this is a strange and likely confusing feature to support. On the PR that added this, @howardjohn showed that AgentGateway supported this feature, so he may have a clearer use case for this. The only use case I can think of here is to redirect only a portion of traffic. IE a traffic split where one "backend" is a redirect and the other goes to a defined backend, but that also seems confusing and unlikely to be desired. |
|
/retitle fix(tests): remove HTTPRouteBackendRequestRedirect feature and related tests |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rikatz, snorwin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
I suggest removing the
HTTPRouteBackendRequestRedirectconformance test along with theHTTPRouteBackendRequestRedirectsupported feature, since they are based on an "invalid" configuration:Defining a
backendRefis pointless if the referenced backend can never receive traffic because aRequestRedirectfilter is attached to it:IMO this is an invalid configuration, as at the HTTPRoute rule level, we already explicitly forbid combining a RequestRedirect filter with backendRefs via API validation (CEL). It's inconsistent to allow the same combination on a backendRef itself.
Beyond this change, we should also consider restricting the set of filters allowed per backendRef, since most others (e.g. ExternalAuth, CORS) don't make sense at that level either.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:
Was AI used in preparing this PR?
No
/label ail/0