Skip to content

fix(tests): remove HTTPRouteBackendRequestRedirect feature and related tests - #5279

Merged
kubernetes-prow[bot] merged 1 commit into
kubernetes-sigs:mainfrom
snorwin:remove-backend-redircet-tests
Sep 30, 2026
Merged

kubernetes-prow[bot] merged 1 commit into
kubernetes-sigs:mainfrom
snorwin:remove-backend-redircet-tests

Conversation

@snorwin

@snorwin snorwin commented Sep 21, 2026 •

Copy link
Copy Markdown
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:
I suggest removing the HTTPRouteBackendRequestRedirect conformance test along with the HTTPRouteBackendRequestRedirect supported feature, since they are based on an "invalid" configuration:

Defining a backendRef is pointless if the referenced backend can never receive traffic because a RequestRedirect filter is attached to it:

    backendRefs:
    - name: infra-backend-v1
      port: 8080
      filters:
      - type: RequestRedirect
        requestRedirect:
          path:
            type: ReplaceFullPath
            replaceFullPath: /redirected-full

IMO this is an invalid configuration, as at the HTTPRoute rule level, we already explicitly forbid combining a RequestRedirect filter with backendRefs via API validation (CEL). It's inconsistent to allow the same combination on a backendRef itself.

Beyond this change, we should also consider restricting the set of filters allowed per backendRef, since most others (e.g. ExternalAuth, CORS) don't make sense at that level either.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

Was AI used in preparing this PR?
No
/label ail/0

Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>
@kubernetes-prow kubernetes-prow Bot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. ail/0 Categorizes a PR as having AI Influence Level 0 (human created, no AI) needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 21, 2026
@kubernetes-prow

Copy link
Copy Markdown

This issue is currently awaiting triage.

If Gateway API community members determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 21, 2026
@snorwin

snorwin commented Sep 21, 2026

Copy link
Copy Markdown
Member Author

@tyxeron

@robscott

Copy link
Copy Markdown
Member

I agree that this is a strange and likely confusing feature to support. On the PR that added this, @howardjohn showed that AgentGateway supported this feature, so he may have a clearer use case for this. The only use case I can think of here is to redirect only a portion of traffic. IE a traffic split where one "backend" is a redirect and the other goes to a defined backend, but that also seems confusing and unlikely to be desired.

@robscott

Copy link
Copy Markdown
Member

/retitle fix(tests): remove HTTPRouteBackendRequestRedirect feature and related tests

@kubernetes-prow kubernetes-prow Bot changed the title fix(tests): remove HTTPRouteBackendURLRewrite feature and related tests fix(tests): remove HTTPRouteBackendRequestRedirect feature and related tests Sep 21, 2026
@rikatz

rikatz commented Sep 30, 2026

Copy link
Copy Markdown
Member

/approve
/lgtm
Given any filter behind BackendRef is already marked as Implementation Specific, I think it makes sense to not have a feature to claim or a conformance test tbh

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 30, 2026
@kubernetes-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rikatz, snorwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2026
@kubernetes-prow
kubernetes-prow Bot merged commit f6acf19 into kubernetes-sigs:main Sep 30, 2026
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ail/0 Categorizes a PR as having AI Influence Level 0 (human created, no AI) approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants