Skip to content

build(deps): upgrade to Go 1.27 and re-generate apply configs - #5297

Merged
kubernetes-prow[bot] merged 7 commits into
kubernetes-sigs:mainfrom
snorwin:go-1.27.1
Sep 30, 2026
Merged

kubernetes-prow[bot] merged 7 commits into
kubernetes-sigs:mainfrom
snorwin:go-1.27.1

Conversation

@snorwin

@snorwin snorwin commented Sep 24, 2026 •

Copy link
Copy Markdown
Member

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Upgrades the project to Go 1.27 and regenerates the generated sources. The CI image seems recently moved to Go 1.27, make verify now runs the code generators under 1.27, which produces different comment formatting in applyconfiguration/ than the committed files.

Which issue(s) this PR fixes:

Fixes #5243

Does this PR introduce a user-facing change?:

NONE

Was AI used in preparing this PR?
No
/label ail/0

@kubernetes-prow kubernetes-prow Bot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. ail/0 Categorizes a PR as having AI Influence Level 0 (human created, no AI) needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 24, 2026
@kubernetes-prow

Copy link
Copy Markdown

This issue is currently awaiting triage.

If Gateway API community members determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow kubernetes-prow Bot added needs-priority size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 24, 2026
@kubernetes-prow kubernetes-prow Bot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 24, 2026
@snorwin

snorwin commented Sep 24, 2026

Copy link
Copy Markdown
Member Author

/retest

@snorwin

snorwin commented Sep 24, 2026 •

Copy link
Copy Markdown
Member Author

I would strongly recommend merging the Go 1.27 upgrade before cutting the release-1.7 branch, otherwise cherry-picking later will be really painful.

/cc @kflynn @davidjumani

@snorwin snorwin changed the title build(deps): upgrade to Go 1.27 and re-generate apply configs - #5231 build(deps): upgrade to Go 1.27 and re-generate apply configs Sep 24, 2026
@kubernetes-prow kubernetes-prow Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 25, 2026
@kubernetes-prow kubernetes-prow Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 29, 2026
@kubernetes-prow kubernetes-prow Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 29, 2026
@kubernetes-prow

Copy link
Copy Markdown

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@snorwin

snorwin commented Sep 30, 2026

Copy link
Copy Markdown
Member Author

@robscott @rikatz just ping me when you need a rebase here.

@robscott

Copy link
Copy Markdown
Member

@snorwin once #5124 merges, this one is next in line. I don't think there will be conflicts between the two, so if you can rebase now, we'll get this one merged shortly.

@robscott robscott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although there are merge conflicts, approving this PR so LGTM is all that's needed later.

@kubernetes-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott, snorwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2026
@snorwin

snorwin commented Sep 30, 2026

Copy link
Copy Markdown
Member Author

@robscott since #5124 contains struct literals with embedded types, running go fix would create a diff, so I have to wait until it's merged.

Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>
Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>
snorwin and others added 4 commits September 30, 2026 18:23
Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>
Bumps the non-k8s group with 5 updates in the / directory:

| Package | From | To |
| --- | --- | --- |
| [golang.org/x/net](https://github.com/golang/net) | `0.58.0` | `0.59.0` |
| [golang.org/x/mod](https://github.com/golang/mod) | `0.39.0` | `0.41.0` |
| [golang.org/x/sync](https://github.com/golang/sync) | `0.22.0` | `0.23.0` |
| [google.golang.org/grpc](https://github.com/grpc/grpc-go) | `1.83.1` | `1.84.0` |
| [golang.org/x/tools](https://github.com/golang/tools) | `0.49.0` | `0.50.0` |



Updates `golang.org/x/net` from 0.58.0 to 0.59.0
- [Commits](golang/net@v0.58.0...v0.59.0)

Updates `golang.org/x/mod` from 0.39.0 to 0.41.0
- [Commits](golang/mod@v0.39.0...v0.41.0)

Updates `golang.org/x/sync` from 0.22.0 to 0.23.0
- [Commits](golang/sync@v0.22.0...v0.23.0)

Updates `google.golang.org/grpc` from 1.83.1 to 1.84.0
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.83.1...v1.84.0)

Updates `golang.org/x/tools` from 0.49.0 to 0.50.0
- [Release notes](https://github.com/golang/tools/releases)
- [Commits](golang/tools@v0.49.0...v0.50.0)

---
updated-dependencies:
- dependency-name: golang.org/x/mod
  dependency-version: 0.41.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: non-k8s
- dependency-name: golang.org/x/net
  dependency-version: 0.59.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: non-k8s
- dependency-name: golang.org/x/sync
  dependency-version: 0.23.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: non-k8s
- dependency-name: golang.org/x/tools
  dependency-version: 0.50.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: non-k8s
- dependency-name: google.golang.org/grpc
  dependency-version: 1.83.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: non-k8s
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>
Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>
Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>
@robscott

Copy link
Copy Markdown
Member

/lgtm
/remove-label needs-rebase

@kubernetes-prow

Copy link
Copy Markdown

@robscott: The label(s) /remove-label needs-rebase cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor, ci-short, ci-extended, ci-full, ail/0, ail/1, ail/2, ail/3, ail/4, ail/5. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

Details

In response to this:

/lgtm
/remove-label needs-rebase

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 30, 2026
@robscott robscott removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 30, 2026
@kubernetes-prow
kubernetes-prow Bot merged commit 6d87426 into kubernetes-sigs:main Sep 30, 2026
20 checks passed
rostislavbobo added a commit to rostislavbobo/gateway-api that referenced this pull request Oct 6, 2026
kubernetes-prow Bot pushed a commit that referenced this pull request Oct 8, 2026
…me Hostname Intersection (#5126)

* TLSRoute: Add conformance test with multiple Routes attachment and same Hostname Intersection

* Use SupportGatewayRouteHostnameIntersectionPrecedence for TLSRouteMultipleRoutesAttachmentSameHostnameIntersection conformance test

* Apply changes from /pull/5297
kubernetes-prow Bot pushed a commit that referenced this pull request Oct 8, 2026
…achment and same Hostname Intersection (#5361)

* TLSRoute: Add conformance test with multiple Routes attachment and same Hostname Intersection

* Use SupportGatewayRouteHostnameIntersectionPrecedence for TLSRouteMultipleRoutesAttachmentSameHostnameIntersection conformance test

* Apply changes from /pull/5297

---------

Co-authored-by: Rostislav Bobrovsky <rostislavb@google.com>
mikemorris pushed a commit to mikemorris/gateway-api that referenced this pull request Oct 13, 2026
…me Hostname Intersection (kubernetes-sigs#5126)

* TLSRoute: Add conformance test with multiple Routes attachment and same Hostname Intersection

* Use SupportGatewayRouteHostnameIntersectionPrecedence for TLSRouteMultipleRoutesAttachmentSameHostnameIntersection conformance test

* Apply changes from kubernetes-sigs/pull/5297
@Bobi-Wan

Copy link
Copy Markdown

Hi, in retrospect, is it common practice to bump to latest required version in this project? Can you share
why that is needed and why not bump just the runtime and tooling versions? Downstream components that depend on the gateway-api are now also required to migrate to 1.27 builds, which can be unwanted in a lot of cases.

@snorwin

snorwin commented Nov 16, 2026

Copy link
Copy Markdown
Member Author

@Bobi-Wan like Kubernetes, our main branch moves to the latest Go minor version as soon as possible (KEP-3744: Stay on supported go versions). This also avoids friction with the Kubernetes toolchain and keeps us in sync with k8s.io/apimachinery.

@Bobi-Wan

Bobi-Wan commented Nov 16, 2026 •

Copy link
Copy Markdown

@snorwin The KEP seems to be related to toolchain versions, not minimal required go version (the one set in go.mod).
That is actually what confused me as well, apimachinery v0.37.2 is at go 1.26:
https://github.com/kubernetes/apimachinery/blob/v0.37.2/go.mod#L5
So this is forcing a requirement that isn't coming from upstream.

@snorwin

snorwin commented Nov 16, 2026

Copy link
Copy Markdown
Member Author

@Bobi-Wan I agree with you, we could have kept Go 1.26 in the root module go.mod. I’m not sure exactly why it was bumped. However, I don’t think this justifies a patch release on its own and Kubernetes 1.38 (built with Go 1.27) is due in mid-December anyway. So I’d suggest we leave it as is for now. I will keep this in mind and double-check it during the next Go upgrade.

@Bobi-Wan

Copy link
Copy Markdown

No need for a patch on our side as well. I just wanted to make sure I am not missing something. Thanks for taking the time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ail/0 Categorizes a PR as having AI Influence Level 0 (human created, no AI) approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants