Repository navigation
build(deps): upgrade to Go 1.27 and re-generate apply configs - #5297
Conversation
|
This issue is currently awaiting triage. If Gateway API community members determine this is a relevant issue, they will accept it by applying the The DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
|
I would strongly recommend merging the Go 1.27 upgrade before cutting the release-1.7 branch, otherwise cherry-picking later will be really painful. /cc @kflynn @davidjumani |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
robscott
left a comment
There was a problem hiding this comment.
Although there are merge conflicts, approving this PR so LGTM is all that's needed later.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: robscott, snorwin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>
Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>
Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>
Bumps the non-k8s group with 5 updates in the / directory: | Package | From | To | | --- | --- | --- | | [golang.org/x/net](https://github.com/golang/net) | `0.58.0` | `0.59.0` | | [golang.org/x/mod](https://github.com/golang/mod) | `0.39.0` | `0.41.0` | | [golang.org/x/sync](https://github.com/golang/sync) | `0.22.0` | `0.23.0` | | [google.golang.org/grpc](https://github.com/grpc/grpc-go) | `1.83.1` | `1.84.0` | | [golang.org/x/tools](https://github.com/golang/tools) | `0.49.0` | `0.50.0` | Updates `golang.org/x/net` from 0.58.0 to 0.59.0 - [Commits](golang/net@v0.58.0...v0.59.0) Updates `golang.org/x/mod` from 0.39.0 to 0.41.0 - [Commits](golang/mod@v0.39.0...v0.41.0) Updates `golang.org/x/sync` from 0.22.0 to 0.23.0 - [Commits](golang/sync@v0.22.0...v0.23.0) Updates `google.golang.org/grpc` from 1.83.1 to 1.84.0 - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.83.1...v1.84.0) Updates `golang.org/x/tools` from 0.49.0 to 0.50.0 - [Release notes](https://github.com/golang/tools/releases) - [Commits](golang/tools@v0.49.0...v0.50.0) --- updated-dependencies: - dependency-name: golang.org/x/mod dependency-version: 0.41.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: non-k8s - dependency-name: golang.org/x/net dependency-version: 0.59.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: non-k8s - dependency-name: golang.org/x/sync dependency-version: 0.23.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: non-k8s - dependency-name: golang.org/x/tools dependency-version: 0.50.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: non-k8s - dependency-name: google.golang.org/grpc dependency-version: 1.83.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: non-k8s ... Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>
Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>
Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>
|
/lgtm |
|
@robscott: The label(s) DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
…me Hostname Intersection (#5126) * TLSRoute: Add conformance test with multiple Routes attachment and same Hostname Intersection * Use SupportGatewayRouteHostnameIntersectionPrecedence for TLSRouteMultipleRoutesAttachmentSameHostnameIntersection conformance test * Apply changes from /pull/5297
…achment and same Hostname Intersection (#5361) * TLSRoute: Add conformance test with multiple Routes attachment and same Hostname Intersection * Use SupportGatewayRouteHostnameIntersectionPrecedence for TLSRouteMultipleRoutesAttachmentSameHostnameIntersection conformance test * Apply changes from /pull/5297 --------- Co-authored-by: Rostislav Bobrovsky <rostislavb@google.com>
…me Hostname Intersection (kubernetes-sigs#5126) * TLSRoute: Add conformance test with multiple Routes attachment and same Hostname Intersection * Use SupportGatewayRouteHostnameIntersectionPrecedence for TLSRouteMultipleRoutesAttachmentSameHostnameIntersection conformance test * Apply changes from kubernetes-sigs/pull/5297
|
Hi, in retrospect, is it common practice to bump to latest required version in this project? Can you share |
|
@Bobi-Wan like Kubernetes, our main branch moves to the latest Go minor version as soon as possible (KEP-3744: Stay on supported go versions). This also avoids friction with the Kubernetes toolchain and keeps us in sync with k8s.io/apimachinery. |
|
@snorwin The KEP seems to be related to toolchain versions, not minimal required go version (the one set in go.mod). |
|
@Bobi-Wan I agree with you, we could have kept Go 1.26 in the root module go.mod. I’m not sure exactly why it was bumped. However, I don’t think this justifies a patch release on its own and Kubernetes 1.38 (built with Go 1.27) is due in mid-December anyway. So I’d suggest we leave it as is for now. I will keep this in mind and double-check it during the next Go upgrade. |
|
No need for a patch on our side as well. I just wanted to make sure I am not missing something. Thanks for taking the time! |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Upgrades the project to Go 1.27 and regenerates the generated sources. The CI image seems recently moved to Go 1.27,
make verifynow runs the code generators under 1.27, which produces different comment formatting inapplyconfiguration/than the committed files.Which issue(s) this PR fixes:
Fixes #5243
Does this PR introduce a user-facing change?:
Was AI used in preparing this PR?
No
/label ail/0