Skip to content

GEP-5093: routability: move to experimental - #5304

Merged
kubernetes-prow[bot] merged 2 commits into
kubernetes-sigs:mainfrom
rikatz:routability-experimental-api
Sep 28, 2026
Merged

kubernetes-prow[bot] merged 2 commits into
kubernetes-sigs:mainfrom
rikatz:routability-experimental-api

Conversation

@rikatz

@rikatz rikatz commented Sep 25, 2026

Copy link
Copy Markdown
Member

What type of PR is this?
/area conformance-test

What this PR does / why we need it:

Moves routability GEP to experimental. Address the following concerns:

  • External is removed, Unspecified is added
  • Add proper CEL validation and tests
  • Make a callout that moving from implicit to explicit address request is an open question and a dangerous operation

Which issue(s) this PR fixes:

Part of #5093

Does this PR introduce a user-facing change?:

Move GEP-5093 to experimental

Was AI used in preparing this PR?

/label ail/3

@kubernetes-prow kubernetes-prow Bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/conformance-test Issues or PRs related to Conformance tests. ail/3 Categorizes a PR as having AI Influence Level 3 (AI created, human structure) needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 25, 2026
@kubernetes-prow

Copy link
Copy Markdown

This issue is currently awaiting triage.

If Gateway API community members determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow kubernetes-prow Bot added needs-priority size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 25, 2026
@kubernetes-prow kubernetes-prow Bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/gep PRs related to Gateway Enhancement Proposal(GEP) labels Sep 25, 2026
@rikatz

rikatz commented Sep 25, 2026

Copy link
Copy Markdown
Member Author

/approve cancel

Letting the approval for other maintainers

@kubernetes-prow kubernetes-prow Bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2026

@robscott robscott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rikatz!

Comment thread apis/v1/gateway_types.go Outdated
// Gateway API defines a value for it.
//
// <gateway:experimental:validation:MaxLength=253>
// <gateway:experimental:validation:XValidation:message="Routability must be empty, Cluster, or an implementation-specific prefixed path; gateway.networking.k8s.io is reserved",rule="size(self) == 0 || self == 'Cluster' || (self.matches('^.*/.+$') && !format.dns1123Subdomain().validate(self.split('/')[0]).hasValue() && !self.startsWith('gateway.networking.k8s.io/'))">

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just reserve any name that includes "k8s.io" anywhere to be more broad?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will right now be a problem for the testing / sentinel but yes, I can change it and then make the sentinel test be x-k8s.io

Comment thread apis/v1/gateway_types.go

const (
GatewayAddressRoutabilityDefault GatewayAddressRoutabilityType = ""
GatewayAddressRoutabilityCluster GatewayAddressRoutabilityType = "Cluster"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommend adding a definition of Cluster routability here that ties it to ClusterIP.

Comment thread apis/v1/gateway_types.go Outdated
GatewayConditionAddressesAssigned GatewayConditionType = "AddressesAssigned"

// This reason is used when all requested Gateway addresses were assigned.
GatewayReasonAddressesAssigned GatewayConditionReason = "Assigned"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I think the positive reason is ~always a direct match of the condition reason, so might as well stick with that here even if it's more verbose.

Suggested change
GatewayReasonAddressesAssigned GatewayConditionReason = "Assigned"
GatewayReasonAddressesAssigned GatewayConditionReason = "AddressesAssigned"

Comment thread tests/cel/gateway_experimental_test.go Outdated
{name: "empty prefix status", routability: "/scope", statusAddress: true, wantError: true},
{name: "empty path status", routability: "example.com/", statusAddress: true, wantError: true},
{name: "invalid prefix status", routability: "example..com/scope", statusAddress: true, wantError: true},
{name: "reserved status", routability: "gateway.networking.k8s.io/sentinel", statusAddress: true, wantError: true},

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommend adding some more with k8s.io in various positions within the value

@kubernetes-prow kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2026
@youngnick

Copy link
Copy Markdown
Contributor

LGTM once @robscott's changes are done.

Moves routability GEP to experimental. Address the following
concerns:

* External is removed, Unspecified is added
* Add proper CEL validation and tests
* Make a callout that moving from implicit to explicit address request
is an open question and a dangerous operation
@rikatz
rikatz force-pushed the routability-experimental-api branch from 8b8c75e to f2e0e9c Compare September 28, 2026 18:25

@robscott robscott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rikatz!

/lgtm
/approve

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 28, 2026
@kubernetes-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rikatz

rikatz commented Sep 28, 2026

Copy link
Copy Markdown
Member Author

/hold cancel

@kubernetes-prow kubernetes-prow Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 28, 2026
@kubernetes-prow
kubernetes-prow Bot merged commit a6c67d8 into kubernetes-sigs:main Sep 28, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ail/3 Categorizes a PR as having AI Influence Level 3 (AI created, human structure) approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance-test Issues or PRs related to Conformance tests. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/gep PRs related to Gateway Enhancement Proposal(GEP) lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants