Repository navigation
GEP-5093: routability: move to experimental - #5304
kubernetes-prow[bot] merged 2 commits into
Conversation
|
This issue is currently awaiting triage. If Gateway API community members determine this is a relevant issue, they will accept it by applying the The DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/approve cancel Letting the approval for other maintainers |
| // Gateway API defines a value for it. | ||
| // | ||
| // <gateway:experimental:validation:MaxLength=253> | ||
| // <gateway:experimental:validation:XValidation:message="Routability must be empty, Cluster, or an implementation-specific prefixed path; gateway.networking.k8s.io is reserved",rule="size(self) == 0 || self == 'Cluster' || (self.matches('^.*/.+$') && !format.dns1123Subdomain().validate(self.split('/')[0]).hasValue() && !self.startsWith('gateway.networking.k8s.io/'))"> |
There was a problem hiding this comment.
Maybe just reserve any name that includes "k8s.io" anywhere to be more broad?
There was a problem hiding this comment.
this will right now be a problem for the testing / sentinel but yes, I can change it and then make the sentinel test be x-k8s.io
|
|
||
| const ( | ||
| GatewayAddressRoutabilityDefault GatewayAddressRoutabilityType = "" | ||
| GatewayAddressRoutabilityCluster GatewayAddressRoutabilityType = "Cluster" |
There was a problem hiding this comment.
Recommend adding a definition of Cluster routability here that ties it to ClusterIP.
| GatewayConditionAddressesAssigned GatewayConditionType = "AddressesAssigned" | ||
|
|
||
| // This reason is used when all requested Gateway addresses were assigned. | ||
| GatewayReasonAddressesAssigned GatewayConditionReason = "Assigned" |
There was a problem hiding this comment.
Nit: I think the positive reason is ~always a direct match of the condition reason, so might as well stick with that here even if it's more verbose.
| GatewayReasonAddressesAssigned GatewayConditionReason = "Assigned" | |
| GatewayReasonAddressesAssigned GatewayConditionReason = "AddressesAssigned" |
| {name: "empty prefix status", routability: "/scope", statusAddress: true, wantError: true}, | ||
| {name: "empty path status", routability: "example.com/", statusAddress: true, wantError: true}, | ||
| {name: "invalid prefix status", routability: "example..com/scope", statusAddress: true, wantError: true}, | ||
| {name: "reserved status", routability: "gateway.networking.k8s.io/sentinel", statusAddress: true, wantError: true}, |
There was a problem hiding this comment.
Recommend adding some more with k8s.io in various positions within the value
|
LGTM once @robscott's changes are done. |
Moves routability GEP to experimental. Address the following concerns: * External is removed, Unspecified is added * Add proper CEL validation and tests * Make a callout that moving from implicit to explicit address request is an open question and a dangerous operation
8b8c75e to
f2e0e9c
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: robscott The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
What type of PR is this?
/area conformance-test
What this PR does / why we need it:
Moves routability GEP to experimental. Address the following concerns:
Which issue(s) this PR fixes:
Part of #5093
Does this PR introduce a user-facing change?:
Was AI used in preparing this PR?
/label ail/3