Repository navigation
GEP-5224: Pre-routing: move to experimental - #5315
kubernetes-prow[bot] merged 8 commits into
Conversation
|
This issue is currently awaiting triage. If Gateway API community members determine this is a relevant issue, they will accept it by applying the The DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hi @jaellio. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
|
||
| // SupportGatewayListenerFilters option indicates support for | ||
| // specifying filters on Gateway listeners. | ||
| SupportGatewayListenerFilters FeatureName = "GatewayListenerFilters" |
There was a problem hiding this comment.
@robscott Do I need a filter per externalAuth and extensionRef? And is this naming okay?
There was a problem hiding this comment.
I think this is okay; GatewayListenerFilters is effectively a union feature where it depends on the types of Routes that an implementation supports which phases will be supported. Currently only HTTPRoute (and maybe GRPCRoute) is relevant, but in the future we may add the other routes.
There was a problem hiding this comment.
+1, I don't think we can meaningfully conformance test extRef, but we could extAuth. In the future, we'll probably want a feature for ext auth on Gateway, but I don't think we need to add that before we have a test for it.
| // Requests is an ordered list of pre-routing filters that run on | ||
| // every request accepted on this Listener, before route matching | ||
| // is performed. The list order is load-bearing: | ||
| // implementations MUST execute the filters in the exact order they | ||
| // appear here and MUST NOT reorder them. If an implementation can |
There was a problem hiding this comment.
Two things:
This should have a callout that this only applies to connections with visible HTTP streams and metadata (it's implicit in the "must be HTTP or HTTPS protocol", but it's better to be explicit).
Also, we don't need "The list order is load-bearing:", it's hard for non-English speakers to read, and the spec only needs the part starting from "implementations MUST".
There was a problem hiding this comment.
Updated and clarified a few other lines as well
youngnick
left a comment
There was a problem hiding this comment.
Couple of small things, but mostly LGTM.
|
|
||
| // SupportGatewayListenerFilters option indicates support for | ||
| // specifying filters on Gateway listeners. | ||
| SupportGatewayListenerFilters FeatureName = "GatewayListenerFilters" |
There was a problem hiding this comment.
I think this is okay; GatewayListenerFilters is effectively a union feature where it depends on the types of Routes that an implementation supports which phases will be supported. Currently only HTTPRoute (and maybe GRPCRoute) is relevant, but in the future we may add the other routes.
|
/ok-to-test |
Signed-off-by: Jackie Elliott <jaellio@microsoft.com>
Signed-off-by: Jackie Elliott <jaellio@microsoft.com>
Signed-off-by: Jackie Elliott <jaellio@microsoft.com>
9902a20 to
472f3a8
Compare
| // explicit exception of the `Host` and `:authority` headers, which | ||
| // implementations MUST reject any attempt to modify. Implementations |
There was a problem hiding this comment.
I think we need to be more specific here, since this actually still leaves implementations with 2 options:
- Ignore any modifications to host and authority headers from an extAuth callout
- Reject the request altogether and return a ~500
As I'm thinking about this, it seems like 1) would be preferable, and we should consider it a "SHOULD". IE implementations MUST reject, and the preferred way they do that is by ignoring any modifications, but 2) is also valid.
There was a problem hiding this comment.
Pushed a revision for option 1
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jaellio, robscott The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Jackie Elliott <jaellio@microsoft.com>
Signed-off-by: Jackie Elliott <jaellio@microsoft.com>
Signed-off-by: Jackie Elliott <jaellio@microsoft.com>
|
Thanks @jaellio! /lgtm |
|
/hold cancel |
|
@jaellio would you fix the linter findings please? thanks!! |
Signed-off-by: Jackie Elliott <jaellio@microsoft.com>
Yes, fixed. Sorry for the delayed responses - at a conference this week. |
|
/lgtm |
|
/hold cancel Thanks @jaellio great work! |
What type of PR is this?
/kind gep
What this PR does / why we need it:
Moves pre-routing filter GEP to experimental and addresses the following:
Which issue(s) this PR fixes:
Part of #5224
Does this PR introduce a user-facing change?:
Was AI used in preparing this PR?
/label ail/3