Skip to content

GEP-5224: Pre-routing: move to experimental - #5315

Merged
kubernetes-prow[bot] merged 8 commits into
kubernetes-sigs:mainfrom
jaellio:jaellio/listenerfilterapi
Sep 29, 2026
Merged

kubernetes-prow[bot] merged 8 commits into
kubernetes-sigs:mainfrom
jaellio:jaellio/listenerfilterapi

Conversation

@jaellio

@jaellio jaellio commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind gep

What this PR does / why we need it:

Moves pre-routing filter GEP to experimental and addresses the following:

  • Adds additional CEL validation and relevant tests

Which issue(s) this PR fixes:

Part of #5224

Does this PR introduce a user-facing change?:

Move GEP-5224 to experimental

Was AI used in preparing this PR?

/label ail/3

@kubernetes-prow kubernetes-prow Bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/gep PRs related to Gateway Enhancement Proposal(GEP) ail/3 Categorizes a PR as having AI Influence Level 3 (AI created, human structure) needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 29, 2026
@kubernetes-prow

Copy link
Copy Markdown

This issue is currently awaiting triage.

If Gateway API community members determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow kubernetes-prow Bot added needs-priority size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 29, 2026
@kubernetes-prow

Copy link
Copy Markdown

Hi @jaellio. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Sep 29, 2026
Comment thread pkg/features/gateway.go

// SupportGatewayListenerFilters option indicates support for
// specifying filters on Gateway listeners.
SupportGatewayListenerFilters FeatureName = "GatewayListenerFilters"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robscott Do I need a filter per externalAuth and extensionRef? And is this naming okay?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is okay; GatewayListenerFilters is effectively a union feature where it depends on the types of Routes that an implementation supports which phases will be supported. Currently only HTTPRoute (and maybe GRPCRoute) is relevant, but in the future we may add the other routes.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, I don't think we can meaningfully conformance test extRef, but we could extAuth. In the future, we'll probably want a feature for ext auth on Gateway, but I don't think we need to add that before we have a test for it.

@jaellio
jaellio marked this pull request as ready for review September 29, 2026 00:50
@kubernetes-prow kubernetes-prow Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 29, 2026
@kubernetes-prow
kubernetes-prow Bot requested a review from kl52752 September 29, 2026 00:50
Comment thread apis/v1/gateway_types.go Outdated
Comment on lines +505 to +509
// Requests is an ordered list of pre-routing filters that run on
// every request accepted on this Listener, before route matching
// is performed. The list order is load-bearing:
// implementations MUST execute the filters in the exact order they
// appear here and MUST NOT reorder them. If an implementation can

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things:

This should have a callout that this only applies to connections with visible HTTP streams and metadata (it's implicit in the "must be HTTP or HTTPS protocol", but it's better to be explicit).

Also, we don't need "The list order is load-bearing:", it's hard for non-English speakers to read, and the spec only needs the part starting from "implementations MUST".

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated and clarified a few other lines as well

@youngnick youngnick left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small things, but mostly LGTM.

Comment thread pkg/features/gateway.go

// SupportGatewayListenerFilters option indicates support for
// specifying filters on Gateway listeners.
SupportGatewayListenerFilters FeatureName = "GatewayListenerFilters"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is okay; GatewayListenerFilters is effectively a union feature where it depends on the types of Routes that an implementation supports which phases will be supported. Currently only HTTPRoute (and maybe GRPCRoute) is relevant, but in the future we may add the other routes.

@youngnick

Copy link
Copy Markdown
Contributor

/ok-to-test

@kubernetes-prow kubernetes-prow Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 29, 2026
Signed-off-by: Jackie Elliott <jaellio@microsoft.com>
Signed-off-by: Jackie Elliott <jaellio@microsoft.com>
Signed-off-by: Jackie Elliott <jaellio@microsoft.com>
Signed-off-by: Jackie Elliott <jaellio@microsoft.com>
@jaellio
jaellio force-pushed the jaellio/listenerfilterapi branch from 9902a20 to 472f3a8 Compare September 29, 2026 15:06

@robscott robscott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jaellio!

Comment thread apis/v1/gateway_types.go Outdated
Comment on lines +516 to +517
// explicit exception of the `Host` and `:authority` headers, which
// implementations MUST reject any attempt to modify. Implementations

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to be more specific here, since this actually still leaves implementations with 2 options:

  1. Ignore any modifications to host and authority headers from an extAuth callout
  2. Reject the request altogether and return a ~500

As I'm thinking about this, it seems like 1) would be preferable, and we should consider it a "SHOULD". IE implementations MUST reject, and the preferred way they do that is by ignoring any modifications, but 2) is also valid.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed a revision for option 1

@kubernetes-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jaellio, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 29, 2026
Comment thread apis/v1/gateway_types.go Resolved
Signed-off-by: Jackie Elliott <jaellio@microsoft.com>
Signed-off-by: Jackie Elliott <jaellio@microsoft.com>
Signed-off-by: Jackie Elliott <jaellio@microsoft.com>
@robscott

Copy link
Copy Markdown
Member

Thanks @jaellio!

/lgtm

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 29, 2026
@robscott

Copy link
Copy Markdown
Member

/hold cancel

@kubernetes-prow kubernetes-prow Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 29, 2026
@rikatz

rikatz commented Sep 29, 2026

Copy link
Copy Markdown
Member

@jaellio would you fix the linter findings please? thanks!!

Signed-off-by: Jackie Elliott <jaellio@microsoft.com>
@kubernetes-prow kubernetes-prow Bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Sep 29, 2026
@jaellio

jaellio commented Sep 29, 2026

Copy link
Copy Markdown
Contributor Author

@jaellio would you fix the linter findings please? thanks!!

Yes, fixed. Sorry for the delayed responses - at a conference this week.

@robscott

Copy link
Copy Markdown
Member

/lgtm

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 29, 2026
@rikatz

rikatz commented Sep 29, 2026

Copy link
Copy Markdown
Member

/hold cancel

Thanks @jaellio great work!

@kubernetes-prow kubernetes-prow Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 29, 2026
@kubernetes-prow
kubernetes-prow Bot merged commit 9fbb726 into kubernetes-sigs:main Sep 29, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ail/3 Categorizes a PR as having AI Influence Level 3 (AI created, human structure) approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/gep PRs related to Gateway Enhancement Proposal(GEP) lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants