Repository navigation
[release-1.7] GEP-4768: API refinements and cleanup for XTelemetryPolicy - #5345
Conversation
Address straightforward follow-up refinements for XTelemetryPolicy and GEP-4768 from kubernetes-sigs#5326: - Fix the docstring on TracingConfig.ParentBasedSampling so that it no longer contradicts the ImplementationDefault default on ParentBasedSampling.Mode. - Associate TracingConfig.ServiceName and TracingConfig.SpanName with the TelemetryPolicyTracing extended feature. - Clarify cross-namespace ReferenceGrant requirements and ResolvedRefs status condition behavior (BackendNotFound, InvalidKind, RefNotPermitted) on TracingProvider.BackendRef, and add corresponding PolicyConditionType/PolicyConditionReason constants. - Replace the copy-pasted Hostname validation pattern on ServiceName with `^[a-zA-Z0-9_.:/-]+$` (matching AttributeName), add a tighter OTel-aligned pattern (`^[a-zA-Z0-9_.:/-]+( [a-zA-Z0-9_.:/-]+)*$`) to SpanName, and convert both fields from *string to string with omitempty. - Convert optional struct fields (Tracing, Provider, SamplingRate, ParentBasedSampling) to value structs with omitzero, and add omitzero to XTelemetryPolicy Spec and Status. - Reorder struct definitions in xtelemetrypolicy_types.go and GEP-4768 so TracingConfig immediately follows TelemetryPolicySpec in top-down order.
|
This issue is currently awaiting triage. If Gateway API community members determine this is a relevant issue, they will accept it by applying the The DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: k8s-infra-cherrypick-robot, rikatz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
d42fd30
into
kubernetes-sigs:release-1.7
This is an automated cherry-pick of #5327
/assign robscott
/kind gep