Skip to content

[release-1.7] GEP-4768: API refinements and cleanup for XTelemetryPolicy - #5345

Merged
kubernetes-prow[bot] merged 3 commits into
kubernetes-sigs:release-1.7from
k8s-infra-cherrypick-robot:cherry-pick-5327-to-release-1.7
Oct 6, 2026
Merged

kubernetes-prow[bot] merged 3 commits into
kubernetes-sigs:release-1.7from
k8s-infra-cherrypick-robot:cherry-pick-5327-to-release-1.7

Conversation

@k8s-infra-cherrypick-robot

Copy link
Copy Markdown
Contributor

This is an automated cherry-pick of #5327

/assign robscott

NONE

/kind gep

Address straightforward follow-up refinements for XTelemetryPolicy and
GEP-4768 from kubernetes-sigs#5326:
- Fix the docstring on TracingConfig.ParentBasedSampling so that it no
  longer contradicts the ImplementationDefault default on
  ParentBasedSampling.Mode.
- Associate TracingConfig.ServiceName and TracingConfig.SpanName with
  the TelemetryPolicyTracing extended feature.
- Clarify cross-namespace ReferenceGrant requirements and ResolvedRefs
  status condition behavior (BackendNotFound, InvalidKind,
  RefNotPermitted) on TracingProvider.BackendRef, and add corresponding
  PolicyConditionType/PolicyConditionReason constants.
- Replace the copy-pasted Hostname validation pattern on ServiceName
  with `^[a-zA-Z0-9_.:/-]+$` (matching AttributeName), add a tighter
  OTel-aligned pattern (`^[a-zA-Z0-9_.:/-]+( [a-zA-Z0-9_.:/-]+)*$`) to
  SpanName, and convert both fields from *string to string with
  omitempty.
- Convert optional struct fields (Tracing, Provider, SamplingRate,
  ParentBasedSampling) to value structs with omitzero, and add omitzero
  to XTelemetryPolicy Spec and Status.
- Reorder struct definitions in xtelemetrypolicy_types.go and GEP-4768
  so TracingConfig immediately follows TelemetryPolicySpec in top-down
  order.
@kubernetes-prow kubernetes-prow Bot added release-note-none Denotes a PR that doesn't merit a release note. kind/gep PRs related to Gateway Enhancement Proposal(GEP) needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 6, 2026
@kubernetes-prow kubernetes-prow Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 6, 2026
@kubernetes-prow

Copy link
Copy Markdown

This issue is currently awaiting triage.

If Gateway API community members determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow kubernetes-prow Bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs-priority cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ail Indicates a PR lacks an `ail/0-5` label and requires one. labels Oct 6, 2026
@rikatz

rikatz commented Oct 6, 2026

Copy link
Copy Markdown
Member

/lgtm
/approve
/label ail/0
/hold cancel

@kubernetes-prow kubernetes-prow Bot added ail/0 Categorizes a PR as having AI Influence Level 0 (human created, no AI) and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-ail Indicates a PR lacks an `ail/0-5` label and requires one. labels Oct 6, 2026
@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 6, 2026
@kubernetes-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k8s-infra-cherrypick-robot, rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2026
@kubernetes-prow
kubernetes-prow Bot merged commit d42fd30 into kubernetes-sigs:release-1.7 Oct 6, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ail/0 Categorizes a PR as having AI Influence Level 0 (human created, no AI) approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/gep PRs related to Gateway Enhancement Proposal(GEP) lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants