Repository navigation
[release-1.7] conformance: fix parentRefToString printing a pointer address - #5399
Conversation
parentRefToString checks *p.Namespace != "" but then formats p.Namespace, so %v prints the pointer address instead of the namespace (e.g. 0x19dc6844a870/gw instead of ns1/gw). Dereference the pointer so the log and error messages show the real namespace/name. Add Test_parentRefToString covering no namespace, empty namespace and a set namespace.
|
This issue is currently awaiting triage. If Gateway API community members determine this is a relevant issue, they will accept it by applying the The DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: k8s-infra-cherrypick-robot, rikatz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
7285cf7
into
kubernetes-sigs:release-1.7
This is an automated cherry-pick of #5398
/assign rikatz
/kind bug