Skip to content

[release-1.7] conformance: avoid nil Group panic in listener status matchers - #5411

Merged
kubernetes-prow[bot] merged 1 commit into
kubernetes-sigs:release-1.7from
k8s-infra-cherrypick-robot:cherry-pick-5401-to-release-1.7
Oct 22, 2026
Merged

kubernetes-prow[bot] merged 1 commit into
kubernetes-sigs:release-1.7from
k8s-infra-cherrypick-robot:cherry-pick-5401-to-release-1.7

Conversation

@k8s-infra-cherrypick-robot

Copy link
Copy Markdown
Contributor

This is an automated cherry-pick of #5401

/assign rikatz

NONE

/kind bug

gatewayListenersMatch and listenerSetListenersMatch default an omitted
Group on each expected supported kind to the Gateway API group, but did
so inside the loop over the actual kinds. When the actual list is empty
the loop never runs, Group stays nil, and the "not found" log line
dereferences it, panicking instead of returning false.

Apply the default before looping over the actual kinds so the helpers
return false and log as they do for a non-empty list. Add tests for
both matchers covering an empty actual SupportedKinds list.
@kubernetes-prow kubernetes-prow Bot added the release-note-none Denotes a PR that doesn't merit a release note. label Oct 22, 2026
@kubernetes-prow kubernetes-prow Bot added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 22, 2026
@kubernetes-prow

Copy link
Copy Markdown

This issue is currently awaiting triage.

If Gateway API community members determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow kubernetes-prow Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-priority cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ail Indicates a PR lacks an `ail/0-5` label and requires one. labels Oct 22, 2026
@rikatz

rikatz commented Oct 22, 2026

Copy link
Copy Markdown
Member

/lgtm
/approve
/label ail/0

@kubernetes-prow kubernetes-prow Bot added ail/0 Categorizes a PR as having AI Influence Level 0 (human created, no AI) lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ail Indicates a PR lacks an `ail/0-5` label and requires one. labels Oct 22, 2026
@kubernetes-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k8s-infra-cherrypick-robot, rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2026
@kubernetes-prow
kubernetes-prow Bot merged commit c36d813 into kubernetes-sigs:release-1.7 Oct 22, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ail/0 Categorizes a PR as having AI Influence Level 0 (human created, no AI) approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants