Repository navigation
[release-1.7] conformance: avoid nil Group panic in listener status matchers - #5411
Conversation
gatewayListenersMatch and listenerSetListenersMatch default an omitted Group on each expected supported kind to the Gateway API group, but did so inside the loop over the actual kinds. When the actual list is empty the loop never runs, Group stays nil, and the "not found" log line dereferences it, panicking instead of returning false. Apply the default before looping over the actual kinds so the helpers return false and log as they do for a non-empty list. Add tests for both matchers covering an empty actual SupportedKinds list.
|
This issue is currently awaiting triage. If Gateway API community members determine this is a relevant issue, they will accept it by applying the The DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: k8s-infra-cherrypick-robot, rikatz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
c36d813
into
kubernetes-sigs:release-1.7
This is an automated cherry-pick of #5401
/assign rikatz
/kind bug