Skip to content

Add affinity rules to presets and allow presets to be overriden in jobs - #1058

Merged
kubernetes-prow[bot] merged 3 commits into
kubernetes-sigs:mainfrom
upodroid:preset-patches
Nov 6, 2026
Merged

kubernetes-prow[bot] merged 3 commits into
kubernetes-sigs:mainfrom
upodroid:preset-patches

Conversation

@upodroid

@upodroid upodroid commented Nov 5, 2026 •

Copy link
Copy Markdown
Member

This PR has two changes:

  • set affinity rules via presets
  • allow overriding presets on the job directly (should simplify situations like these, most of these presets exist because we can't override a few env variables)

@pohly @Jefftree

@netlify

netlify Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for k8s-prow ready!

Name Link
🔨 Latest commit e5d7add
🔍 Latest deploy log https://app.netlify.com/projects/k8s-prow/deploys/6aed19c09b636a49af8fc55a
😎 Deploy Preview https://deploy-preview-1058--k8s-prow.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@kubernetes-prow kubernetes-prow Bot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 5, 2026
@kubernetes-prow
kubernetes-prow Bot requested review from Prucek and cjwagner November 5, 2026 12:38
@kubernetes-prow kubernetes-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 5, 2026
@upodroid

upodroid commented Nov 5, 2026

Copy link
Copy Markdown
Member Author

/cc @cblecker

@kubernetes-prow
kubernetes-prow Bot requested a review from cblecker November 5, 2026 13:46
@Jefftree

Jefftree commented Nov 5, 2026

Copy link
Copy Markdown
Member

Huge +1 thank you!

Comment thread pkg/config/jobs_test.go Resolved
Comment thread pkg/config/jobs.go Resolved
Comment thread pkg/config/jobs.go Resolved
@kubernetes-prow kubernetes-prow Bot added the area/documentation Issues or PRs related to documentation label Nov 5, 2026
@upodroid

upodroid commented Nov 5, 2026

Copy link
Copy Markdown
Member Author

/label tide/merge-method-squash

@kubernetes-prow kubernetes-prow Bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 5, 2026
@upodroid

upodroid commented Nov 5, 2026

Copy link
Copy Markdown
Member Author

I addressed all the comments

Comment thread site/content/en/docs/jobs.md Resolved
Comment thread site/content/en/docs/jobs.md Resolved
Comment thread site/content/en/docs/jobs.md Resolved
@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 6, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2026
@kubernetes-prow
kubernetes-prow Bot merged commit 9f4d186 into kubernetes-sigs:main Nov 6, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants