Add go.mod for Go modules - #1187
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1187 +/- ##
=======================================
Coverage 81.34% 81.34%
=======================================
Files 25 25
Lines 1919 1919
=======================================
Hits 1561 1561
Misses 250 250
Partials 108 108Continue to review full report at Codecov.
|
Contributor
Author
|
Sync with labstack's master branch. |
Member
|
@im-kulikov Can you review this? |
Contributor
im-kulikov
reviewed
Aug 31, 2018
| Learn more at https://echo.labstack.com | ||
| */ | ||
| package echo | ||
| package echo // import "github.com/labstack/echo" |
im-kulikov
reviewed
Aug 31, 2018
im-kulikov
reviewed
Aug 31, 2018
im-kulikov
left a comment
im-kulikov
left a comment
Contributor
There was a problem hiding this comment.
pls add go.sum
package echo // import "github.com/labstack/echo"
not required
Contributor
Author
|
Thank you for reviewing my PR. I will modify that and recommit it ASAP. |
KimMachineGun
force-pushed
the
add-gomod
branch
from
September 2, 2018 13:26
2ca86d3 to
9b4d027
Compare
Contributor
Author
|
I resolved it. |
im-kulikov
approved these changes
Sep 4, 2018
Contributor
|
LGTM |
vishr
approved these changes
Sep 4, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.